Splitting Instrumentation Projects #890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cijothomas
reviewed
Jul 23, 2020
cijothomas
reviewed
Jul 23, 2020
cijothomas
reviewed
Jul 23, 2020
src/OpenTelemetry.Instrumentation.Grpc/OpenTelemetry.Instrumentation.Grpc.csproj
Show resolved
Hide resolved
cijothomas
reviewed
Jul 23, 2020
src/OpenTelemetry.Instrumentation.Grpc/OpenTelemetry.Instrumentation.Grpc.csproj
Outdated
Show resolved
Hide resolved
cijothomas
reviewed
Jul 23, 2020
src/OpenTelemetry.Instrumentation.Grpc/OpenTelemetryBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
cijothomas
reviewed
Jul 23, 2020
src/OpenTelemetry.Instrumentation.Grpc/OpenTelemetryBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
cijothomas
reviewed
Jul 23, 2020
src/OpenTelemetry.Instrumentation.Http/OpenTelemetryBuilderExtensions.cs
Show resolved
Hide resolved
cijothomas
reviewed
Jul 23, 2020
src/OpenTelemetry.Instrumentation.SqlClient/OpenTelemetryBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
cijothomas
approved these changes
Jul 23, 2020
updating README updating sql integration test updating yml updating dockerfile updating readme updating global.asax updating version and readme removing unused reference, adding properties folder to be similar to OT project adding zipkin docker in comments updating to standard2.1 removing unused usings updating aspnet/aspnetcore methods naming applying cijo's suggestions updating projects to compile semantic file, updating comments Splitting Instrumentation Projects updating README updating sql integration test updating yml updating dockerfile updating readme updating global.asax updating version and readme removing unused reference, adding properties folder to be similar to OT project adding zipkin docker in comments updating to standard2.1 removing unused usings applying cijo's suggestions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #888.
Changes
For significant contributions please make sure you have completed the following items: