Skip to content

[OpenTelemetry] Update wildcard regex - #7760

Merged
martincostello merged 3 commits into
open-telemetry:mainfrom
martincostello:add-regex-timeout
Sep 15, 2026
Merged

martincostello merged 3 commits into
open-telemetry:mainfrom
martincostello:add-regex-timeout

Conversation

@martincostello

Copy link
Copy Markdown
Member

Changes

  • Disable backtracking in modern .NET.
  • Add match timeout when targeting .NET Framework.

Found by a scan of the repository code using Claude Code.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

- Disable backtracking in modern .NET.
- Add match timeout when targeting .NET Framework.
Comment thread src/OpenTelemetry/CHANGELOG.md Outdated
@codecov

codecov Bot commented Sep 15, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.86%. Comparing base (7dbd68d) to head (cec6241).
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #7760   +/-   ##
=======================================
  Coverage   91.85%   91.86%           
=======================================
  Files         337      337           
  Lines       18399    18410   +11     
=======================================
+ Hits        16901    16912   +11     
  Misses       1498     1498           
Flag Coverage Δ
unittests-Project-Experimental 91.92% <100.00%> (-0.06%) ⬇️
unittests-Project-Stable 91.94% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/OpenTelemetry/Internal/WildcardHelper.cs 100.00% <100.00%> (ø)
.../Metrics/Builder/MeterProviderBuilderExtensions.cs 98.57% <100.00%> (+0.04%) ⬆️
src/OpenTelemetry/Metrics/MeterProviderSdk.cs 92.91% <100.00%> (ø)
src/OpenTelemetry/Trace/TracerProviderSdk.cs 97.36% <100.00%> (ø)

@github-actions github-actions Bot added the pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package label Sep 15, 2026
@martincostello
martincostello requested a balanced review from Copilot September 15, 2026 16:35

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The implementation is consistent and regression-tested; only minor changelog wording needs correction.

Review details
  • Files reviewed: 6/6 changed files
  • Comments generated: 1
  • Review effort level: Balanced

Comment thread src/OpenTelemetry/CHANGELOG.md Outdated
Comment thread src/OpenTelemetry/CHANGELOG.md Outdated
Apply feedback on entry text.
@martincostello
martincostello marked this pull request as ready for review September 15, 2026 16:48
@martincostello
martincostello requested a review from a team as a code owner September 15, 2026 16:48
This was referenced Oct 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants