Skip to content

[Exporter.Prometheus] Log when metric ignored - #7429

Merged
martincostello merged 3 commits into
open-telemetry:mainfrom
martincostello:warn-when-histogram-dropped
Jun 19, 2026
Merged

[Exporter.Prometheus] Log when metric ignored#7429
martincostello merged 3 commits into
open-telemetry:mainfrom
martincostello:warn-when-histogram-dropped

Conversation

@martincostello

Copy link
Copy Markdown
Member

Changes

Log a verbose message to the event log when a metric is ignored.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

Log a verbose message to the event log when a metric is ignored.
Comment thread src/OpenTelemetry.Exporter.Prometheus.AspNetCore/CHANGELOG.md Outdated
@github-actions github-actions Bot added pkg:OpenTelemetry.Exporter.Prometheus.AspNetCore Issues related to OpenTelemetry.Exporter.Prometheus.AspNetCore NuGet package pkg:OpenTelemetry.Exporter.Prometheus.HttpListener Issues related to OpenTelemetry.Exporter.Prometheus.HttpListener NuGet package labels Jun 19, 2026
Comment thread src/OpenTelemetry.Exporter.Prometheus.HttpListener/CHANGELOG.md Outdated
@codecov

codecov Bot commented Jun 19, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.96%. Comparing base (7800d8c) to head (57c288b).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...r/Internal/Shared/PrometheusExporterEventSource.cs 50.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7429      +/-   ##
==========================================
- Coverage   90.03%   89.96%   -0.07%     
==========================================
  Files         277      277              
  Lines       14628    14631       +3     
==========================================
- Hits        13170    13163       -7     
- Misses       1458     1468      +10     
Flag Coverage Δ
unittests-Project-Experimental 89.88% <66.66%> (-0.07%) ⬇️
unittests-Project-Stable 89.89% <66.66%> (-0.06%) ⬇️
unittests-UnstableCoreLibraries-Experimental 48.85% <66.66%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ner/Internal/Shared/PrometheusCollectionManager.cs 90.26% <100.00%> (+0.05%) ⬆️
...ernal/Shared/Serialization/TextFormatSerializer.cs 100.00% <ø> (ø)
...r/Internal/Shared/PrometheusExporterEventSource.cs 48.14% <50.00%> (+0.32%) ⬆️

... and 4 files with indirect coverage changes

@martincostello
martincostello marked this pull request as ready for review June 19, 2026 10:28
@martincostello
martincostello requested a review from a team as a code owner June 19, 2026 10:28
@martincostello
martincostello enabled auto-merge June 19, 2026 10:28
@martincostello
martincostello added this pull request to the merge queue Jun 19, 2026
Merged via the queue into open-telemetry:main with commit 98c3e0c Jun 19, 2026
76 checks passed
@martincostello
martincostello deleted the warn-when-histogram-dropped branch June 19, 2026 12:45
This was referenced Aug 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg:OpenTelemetry.Exporter.Prometheus.AspNetCore Issues related to OpenTelemetry.Exporter.Prometheus.AspNetCore NuGet package pkg:OpenTelemetry.Exporter.Prometheus.HttpListener Issues related to OpenTelemetry.Exporter.Prometheus.HttpListener NuGet package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants