Skip to content

[OpenTelemetry] Fix metricpoint race on ARM - #7401

Merged
martincostello merged 5 commits into
open-telemetry:mainfrom
martincostello:fix-arm-failure
Jun 16, 2026
Merged

[OpenTelemetry] Fix metricpoint race on ARM#7401
martincostello merged 5 commits into
open-telemetry:mainfrom
martincostello:fix-arm-failure

Conversation

@martincostello

Copy link
Copy Markdown
Member

Changes

Fix flaky read on ARM that Claude code suggests is the root cause for test flakiness due to its weaker memory model in MetricPointReclaimTests found while working on #7400.

I can't validate this either way locally, so I told Claude to assume it was true and write a test to prove it in CI.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

Fix flaky read on ARM that Claude suggests is the root cause for test flakiness in `MetricPointReclaimTests`.
@github-actions github-actions Bot added the pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package label Jun 11, 2026
@codecov

codecov Bot commented Jun 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.74%. Comparing base (6936f7e) to head (4d02376).
⚠️ Report is 6 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7401      +/-   ##
==========================================
+ Coverage   89.71%   89.74%   +0.03%     
==========================================
  Files         276      276              
  Lines       14576    14582       +6     
==========================================
+ Hits        13077    13087      +10     
+ Misses       1499     1495       -4     
Flag Coverage Δ
unittests-Project-Experimental 89.64% <100.00%> (+0.14%) ⬆️
unittests-Project-Stable 89.65% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/OpenTelemetry/Metrics/AggregatorStore.cs 89.38% <100.00%> (+1.06%) ⬆️
...c/OpenTelemetry/Metrics/MetricPoint/MetricPoint.cs 94.92% <100.00%> (+0.07%) ⬆️

Make further changes to try to resolve issue.
Comment thread test/OpenTelemetry.Tests/Metrics/MetricPointReclaimTests.cs Outdated
Comment thread src/OpenTelemetry/CHANGELOG.md Outdated
- Add PR number to CHANGELOG.
- Remove redundant comment from test.
- Add parameter to test `MetricReaderTemporalityPreference.Delta`.
- Resolve TODO by using `Random.Shared` (which is thread-safe) where available.
- Remove comment with old results.
@github-actions github-actions Bot added the perf Performance related label Jun 11, 2026
@martincostello
martincostello marked this pull request as ready for review June 11, 2026 14:14
@martincostello
martincostello requested a review from a team as a code owner June 11, 2026 14:14
@martincostello
martincostello enabled auto-merge June 11, 2026 14:14
Comment thread test/Benchmarks/Metrics/MetricCollectBenchmarks.cs
This was referenced Aug 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

perf Performance related pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants