-
Notifications
You must be signed in to change notification settings - Fork 849
[Infra] Attest DLLs with GitHub Attestations #6646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Use GitHub Attestations to attest DLL files created by the build. Resolves open-telemetry#6350.
Only attest the `OpenTelemetry*` DLLs.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6646 +/- ##
==========================================
+ Coverage 86.76% 86.80% +0.04%
==========================================
Files 258 258
Lines 11958 11958
==========================================
+ Hits 10375 10380 +5
+ Misses 1583 1578 -5
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds GitHub Artifact Attestations to DLLs in NuGet packages to provide cryptographic verification of build provenance, starting with the 1.14.0 release.
Key Changes:
- Adds attestation workflow step to generate build provenance for DLL files
- Updates documentation with instructions for verifying DLL attestations using GitHub CLI
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/workflows/publish-packages-1.0.yml | Adds attestations permission and workflow step to attest DLLs using GitHub's attest-build-provenance action |
| README.md | Documents the new attestation feature and provides verification instructions for users |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool, answers my question about uses of attestations outside of immutable releases: open-telemetry/sig-security#164 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @trask
Fixes #6350
Changes
Use GitHub Attestations to attest DLL files created by the build.
Validation
OpenTelemetry.1.11.3-alpha.0.306.nupkg, and runninggh attestation verify --owner martincostello .\OpenTelemetry.dllfromlib\net8.0gives the output below:Merge requirement checklist
Unit tests added/updatedAppropriateCHANGELOG.mdfiles updated for non-trivial changesChanges in public API reviewed (if applicable)