Skip to content

Self-diagnostics - support formatted message for better human readability #6411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Aug 5, 2025

Conversation

cijothomas
Copy link
Member

Fixes #6242

@cijothomas cijothomas requested a review from a team as a code owner July 26, 2025 01:58
@github-actions github-actions bot added infra Infra work - CI/CD, code coverage, linters pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package labels Jul 26, 2025
@github-actions github-actions bot removed the infra Infra work - CI/CD, code coverage, linters label Jul 26, 2025
Copy link

codecov bot commented Jul 26, 2025

Codecov Report

❌ Patch coverage is 88.46154% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.66%. Comparing base (27234c2) to head (84a1045).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...Telemetry/Internal/SelfDiagnosticsEventListener.cs 75.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #6411   +/-   ##
=======================================
  Coverage   86.66%   86.66%           
=======================================
  Files         258      258           
  Lines       11858    11873   +15     
=======================================
+ Hits        10277    10290   +13     
- Misses       1581     1583    +2     
Flag Coverage Δ
unittests-Project-Experimental 86.26% <88.46%> (+<0.01%) ⬆️
unittests-Project-Stable 86.56% <88.46%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...nTelemetry/Internal/SelfDiagnosticsConfigParser.cs 88.13% <100.00%> (+2.42%) ⬆️
...lemetry/Internal/SelfDiagnosticsConfigRefresher.cs 87.03% <100.00%> (+0.12%) ⬆️
...Telemetry/Internal/SelfDiagnosticsEventListener.cs 96.26% <75.00%> (+0.11%) ⬆️

... and 5 files with indirect coverage changes

Copy link
Contributor

@rajkumar-rangaraj rajkumar-rangaraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@xiang17 xiang17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor feedbacks

@alanwest alanwest merged commit d2f8e54 into open-telemetry:main Aug 5, 2025
43 checks passed
@cijothomas cijothomas deleted the cijothoma/self-diag-format branch August 5, 2025 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request] Improve SDK logging output for more efficient troubleshooting
6 participants