Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Extensions.Hosting.Tests] Nullable #5862

Merged
merged 10 commits into from
Oct 1, 2024

Conversation

ysolomchenko
Copy link
Contributor

Towards #3958

Changes

Extensions.Hosting.Tests mark as nullable

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@github-actions github-actions bot added the pkg:OpenTelemetry.Extensions.Hosting Issues related to OpenTelemetry.Extensions.Hosting NuGet package label Sep 25, 2024
@github-actions github-actions bot added the pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package label Sep 26, 2024
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.33%. Comparing base (6250307) to head (d9c0c26).
Report is 336 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5862      +/-   ##
==========================================
+ Coverage   83.38%   86.33%   +2.95%     
==========================================
  Files         297      257      -40     
  Lines       12531    11214    -1317     
==========================================
- Hits        10449     9682     -767     
+ Misses       2082     1532     -550     
Flag Coverage Δ
unittests ?
unittests-Project-Experimental 86.00% <ø> (?)
unittests-Project-Stable 86.21% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 234 files with indirect coverage changes

@ysolomchenko ysolomchenko marked this pull request as ready for review September 26, 2024 08:07
@ysolomchenko ysolomchenko requested a review from a team as a code owner September 26, 2024 08:07
@TimothyMothra
Copy link
Contributor

Did you intend to do two projects in this PR; OpenTelemetry.Extensions.Hosting.Tests and OpenTelemetry.Tests?

@ysolomchenko
Copy link
Contributor Author

@TimothyMothra some files from the OpenTelemetry.Tests project were imported using include, so I made them nullable. However, I would prefer to update OpenTelemetry.Tests in a separate PR.

@CodeBlanch CodeBlanch merged commit 19e1663 into open-telemetry:main Oct 1, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:OpenTelemetry.Extensions.Hosting Issues related to OpenTelemetry.Extensions.Hosting NuGet package pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants