-
Notifications
You must be signed in to change notification settings - Fork 765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Extensions.Hosting.Tests] Nullable #5862
[Extensions.Hosting.Tests] Nullable #5862
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5862 +/- ##
==========================================
+ Coverage 83.38% 86.33% +2.95%
==========================================
Files 297 257 -40
Lines 12531 11214 -1317
==========================================
- Hits 10449 9682 -767
+ Misses 2082 1532 -550
Flags with carried forward coverage won't be shown. Click here to find out more. |
Did you intend to do two projects in this PR; OpenTelemetry.Extensions.Hosting.Tests and OpenTelemetry.Tests? |
@TimothyMothra some files from the OpenTelemetry.Tests project were imported using include, so I made them nullable. However, I would prefer to update OpenTelemetry.Tests in a separate PR. |
Towards #3958
Changes
Extensions.Hosting.Tests mark as nullable
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial changes