Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Logs Bridge API] Add support for Body set directly on LogRecord for OTLP Exporter. #5268

Merged
merged 16 commits into from
Feb 1, 2024
Merged

[Logs Bridge API] Add support for Body set directly on LogRecord for OTLP Exporter. #5268

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
74821cf
initial
Yun-Ting Jan 26, 2024
db1d47e
merge main
Yun-Ting Jan 26, 2024
4e4b6a6
fix merge
Yun-Ting Jan 26, 2024
3679052
if
Yun-Ting Jan 26, 2024
e00e64e
comment and changelog
Yun-Ting Jan 26, 2024
eff6533
addressed comments
Yun-Ting Jan 27, 2024
ed0385f
fix preprocessor
Yun-Ting Jan 27, 2024
47dc823
convention
Yun-Ting Jan 27, 2024
97eaf0a
Code review.
CodeBlanch Jan 29, 2024
b2162c3
Merge branch 'main' into yunl/logBridgeBody
CodeBlanch Jan 30, 2024
367ff23
comment
Yun-Ting Jan 30, 2024
eef83a4
addressed a comment
Yun-Ting Jan 31, 2024
b0e8be7
Merge branch 'main' into yunl/logBridgeBody
Yun-Ting Jan 31, 2024
57599fe
Apply suggestions from code review
Yun-Ting Jan 31, 2024
1750d6d
Merge branch 'main' into yunl/logBridgeBody
Yun-Ting Feb 1, 2024
f4de1f5
CHANGELOG tweak.
CodeBlanch Feb 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix preprocessor
  • Loading branch information
@Yun-Ting
Yun-Ting committed Jan 27, 2024
commit ed0385f1a72408d6ed84c1c6eaabecdf011c188e
2 changes: 0 additions & 2 deletions test/OpenTelemetry.Exporter.OpenTelemetryProtocol.Tests/OtlpLogExporterTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -589,7 +589,6 @@ public void CheckToOtlpLogRecordBodyIsPopulated(bool includeFormattedMessage)
Assert.Equal("state", otlpLogRecord.Body.StringValue);
}

#if NET8_0_OR_GREATER
[Fact]
public void LogRecordBodyIsExportedWhenUsingBridgeApi()
Yun-Ting marked this conversation as resolved.
Show resolved Hide resolved
{
Expand Down Expand Up @@ -621,7 +620,6 @@ public void LogRecordBodyIsExportedWhenUsingBridgeApi()

Assert.Equal("Hello world", otlpLogRecord.Body?.StringValue);
}
#endif

[Fact]
public void CheckToOtlpLogRecordExceptionAttributes()
Expand Down
Loading