Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hosting] Support .NET 8 IMetricsBuilder API #4958

Merged
merged 53 commits into from
Nov 22, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
53 commits
Select commit Hold shift + click to select a range
9331203
Implement an IMetricsListener over OpenTelemetry SDK.
CodeBlanch Jul 28, 2023
b70f529
Tweak.
CodeBlanch Jul 28, 2023
e411e22
Tweak.
CodeBlanch Jul 28, 2023
dc4f60e
Merge from main.
CodeBlanch Oct 9, 2023
6db3bcb
Manually fix merge conflicts and update API to released versions.
CodeBlanch Oct 9, 2023
680c506
Package updates.
CodeBlanch Oct 9, 2023
496002f
Ceremony.
CodeBlanch Oct 10, 2023
3a03fa3
Fixed dropped metrics in IMetricsBuilder when composite reader is used.
CodeBlanch Oct 14, 2023
558df37
Rename API and add todo.
CodeBlanch Oct 16, 2023
32a0388
Define SDK AddOpenTelemetryLogging extension.
CodeBlanch Oct 16, 2023
25e7ef9
Bug fixes.
CodeBlanch Oct 17, 2023
5ea6211
Merge from main.
CodeBlanch Oct 17, 2023
5d645eb
Merge from main.
CodeBlanch Oct 19, 2023
82b384d
Port public api updates.
CodeBlanch Oct 19, 2023
f4c254a
Merge branch 'main' into poc/metricsbuilder
CodeBlanch Oct 24, 2023
995d2c4
Merge branch 'main' into poc/metricsbuilder
CodeBlanch Nov 1, 2023
9c87e60
Code review.
CodeBlanch Nov 1, 2023
3fd9045
Warning cleanup.
CodeBlanch Nov 1, 2023
c507377
Test coverage.
CodeBlanch Nov 6, 2023
fe10eb6
Merge from main.
CodeBlanch Nov 6, 2023
24322e8
Merge fixes.
CodeBlanch Nov 6, 2023
3fe5702
Test coverage for the UseOpenTelemetry logging extension.
CodeBlanch Nov 7, 2023
bfec275
Ignore external subscriptions if AddMeter is also called.
CodeBlanch Nov 9, 2023
c728717
Verify hot reload of metrics via IConfiguration works and doesn't pro…
CodeBlanch Nov 10, 2023
934e75b
Switch WithLogging and WithMetrics to turn on hosting features.
CodeBlanch Nov 13, 2023
467008e
Make IMetricsBuilder.UseOpenTelemetry an experimental API.
CodeBlanch Nov 13, 2023
f22cdf8
XML comment tweaks.
CodeBlanch Nov 13, 2023
f5b2e6f
Test fix.
CodeBlanch Nov 13, 2023
ec19a81
Warning cleanup.
CodeBlanch Nov 13, 2023
01114b3
Update WithMetrics XML comments to capture the IMetricsListener behav…
CodeBlanch Nov 14, 2023
4012f83
Make IMetricsBuilder.UseOpenTelemetry internal.
CodeBlanch Nov 14, 2023
cd393f7
Remove logging changes.
CodeBlanch Nov 14, 2023
1500698
Remove more logging changes.
CodeBlanch Nov 14, 2023
c2cb6be
Merge from main.
CodeBlanch Nov 15, 2023
0b623e9
A few misc changes and fixes.
CodeBlanch Nov 15, 2023
9831c9f
Merge from main.
CodeBlanch Nov 16, 2023
6905583
Refactor a little bit of duplicated code.
CodeBlanch Nov 16, 2023
cc195ba
Code review.
CodeBlanch Nov 17, 2023
d993289
Code review.
CodeBlanch Nov 17, 2023
0862f7f
Code review.
CodeBlanch Nov 17, 2023
f73d309
Code review and race condition cleanup.
CodeBlanch Nov 17, 2023
da5554b
Tweak.
CodeBlanch Nov 17, 2023
f748914
Reuse metric instances when an instrument is reactivated.
CodeBlanch Nov 18, 2023
7685521
Expand TODOs.
CodeBlanch Nov 18, 2023
8c4c9d2
Merge branch 'main' into poc/metricsbuilder
CodeBlanch Nov 20, 2023
54da2d9
Lower reference to Microsoft.Extensions.Diagnostics.Abstractions.
CodeBlanch Nov 20, 2023
97f3bf5
Warning cleanup.
CodeBlanch Nov 20, 2023
abbcbb1
Revert logging options ordering change.
CodeBlanch Nov 21, 2023
7744d5e
Code review.
CodeBlanch Nov 21, 2023
9ab7c58
CHANGELOG update.
CodeBlanch Nov 21, 2023
f2fce4a
Test tweak.
CodeBlanch Nov 21, 2023
152220c
Merge remote-tracking branch 'upstream/main' into poc/metricsbuilder
CodeBlanch Nov 21, 2023
1c264e8
Clean up nits.
CodeBlanch Nov 21, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Lower reference to Microsoft.Extensions.Diagnostics.Abstractions.
  • Loading branch information
CodeBlanch committed Nov 20, 2023
commit 54da2d997ada4172ca774404c85cb6b5b7f69a22
2 changes: 1 addition & 1 deletion Directory.Packages.props
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@

<PackageVersion Include="Microsoft.Extensions.Configuration" Version="8.0.0" />
<PackageVersion Include="Microsoft.Extensions.DependencyInjection.Abstractions" Version="8.0.0" />
<PackageVersion Include="Microsoft.Extensions.Diagnostics" Version="8.0.0" />
<PackageVersion Include="Microsoft.Extensions.Diagnostics.Abstractions" Version="8.0.0" />
<PackageVersion Include="Microsoft.Extensions.Hosting.Abstractions" Version="8.0.0" />
<PackageVersion Include="Microsoft.Extensions.Logging" Version="8.0.0" />
<PackageVersion Include="Microsoft.Extensions.Logging.Configuration" Version="8.0.0" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@

<ItemGroup>
<PackageReference Include="Microsoft.Extensions.Hosting.Abstractions" />
<PackageReference Include="Microsoft.Extensions.Diagnostics" />
<PackageReference Include="Microsoft.Extensions.Diagnostics.Abstractions" />
</ItemGroup>

<ItemGroup>
Expand Down
12 changes: 6 additions & 6 deletions src/OpenTelemetry.Extensions.Hosting/OpenTelemetryBuilder.cs
Original file line number Diff line number Diff line change
Expand Up @@ -82,10 +82,9 @@ public OpenTelemetryBuilder ConfigureResource(
/// <item>This is safe to be called multiple times and by library authors.
/// Only a single <see cref="MeterProvider"/> will be created for a given
/// <see cref="IServiceCollection"/>.</item>
/// <item>This method automatically calls <see
/// cref="MetricsServiceExtensions.AddMetrics(IServiceCollection)"/> and
/// registers an <see cref="IMetricsListener"/> named 'OpenTelemetry' into
/// the <see cref="IServiceCollection"/>.</item>
/// <item>This method automatically registers an <see
/// cref="IMetricsListener"/> named 'OpenTelemetry' into the <see
/// cref="IServiceCollection"/>.</item>
/// </list>
/// </remarks>
/// <returns>The supplied <see cref="OpenTelemetryBuilder"/> for chaining
Expand All @@ -103,8 +102,9 @@ public OpenTelemetryBuilder WithMetrics()
/// calls.</returns>
public OpenTelemetryBuilder WithMetrics(Action<MeterProviderBuilder> configure)
{
this.Services.AddMetrics(
builder => builder.UseOpenTelemetry(configure));
OpenTelemetryMetricsBuilderExtensions.RegisterMetricsListener(
this.Services,
configure);

return this;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
// limitations under the License.
// </copyright>

using System.Diagnostics;
using Microsoft.Extensions.DependencyInjection;
using Microsoft.Extensions.DependencyInjection.Extensions;
using OpenTelemetry.Internal;
Expand Down Expand Up @@ -56,15 +57,25 @@
Action<MeterProviderBuilder> configure)
{
Guard.ThrowIfNull(metricsBuilder);

RegisterMetricsListener(metricsBuilder.Services, configure);

return metricsBuilder;
}

internal static void RegisterMetricsListener(
IServiceCollection services,
Action<MeterProviderBuilder> configure)
{
Debug.Assert(services != null, "services was null");

Guard.ThrowIfNull(configure);

var builder = new MeterProviderBuilderBase(metricsBuilder.Services);
var builder = new MeterProviderBuilderBase(services);

Check failure on line 74 in src/OpenTelemetry.Extensions.Hosting/OpenTelemetryMetricsBuilderExtensions.cs

View workflow job for this annotation

GitHub Actions / build-test-experimental (ubuntu-latest, net7.0)

Possible null reference argument for parameter 'services' in 'MeterProviderBuilderBase.MeterProviderBuilderBase(IServiceCollection services)'.

Check failure on line 74 in src/OpenTelemetry.Extensions.Hosting/OpenTelemetryMetricsBuilderExtensions.cs

View workflow job for this annotation

GitHub Actions / build-test-experimental (ubuntu-latest, net7.0)

Possible null reference argument for parameter 'services' in 'MeterProviderBuilderBase.MeterProviderBuilderBase(IServiceCollection services)'.

Check failure on line 74 in src/OpenTelemetry.Extensions.Hosting/OpenTelemetryMetricsBuilderExtensions.cs

View workflow job for this annotation

GitHub Actions / build-test-experimental (ubuntu-latest, net7.0)

Possible null reference argument for parameter 'services' in 'MeterProviderBuilderBase.MeterProviderBuilderBase(IServiceCollection services)'.

Check failure on line 74 in src/OpenTelemetry.Extensions.Hosting/OpenTelemetryMetricsBuilderExtensions.cs

View workflow job for this annotation

GitHub Actions / build-test-experimental (ubuntu-latest, net7.0)

Possible null reference argument for parameter 'services' in 'MeterProviderBuilderBase.MeterProviderBuilderBase(IServiceCollection services)'.

Check failure on line 74 in src/OpenTelemetry.Extensions.Hosting/OpenTelemetryMetricsBuilderExtensions.cs

View workflow job for this annotation

GitHub Actions / build-test-stable (ubuntu-latest, net6.0)

Possible null reference argument for parameter 'services' in 'MeterProviderBuilderBase.MeterProviderBuilderBase(IServiceCollection services)'.

Check failure on line 74 in src/OpenTelemetry.Extensions.Hosting/OpenTelemetryMetricsBuilderExtensions.cs

View workflow job for this annotation

GitHub Actions / build-test-stable (ubuntu-latest, net6.0)

Possible null reference argument for parameter 'services' in 'MeterProviderBuilderBase.MeterProviderBuilderBase(IServiceCollection services)'.

Check failure on line 74 in src/OpenTelemetry.Extensions.Hosting/OpenTelemetryMetricsBuilderExtensions.cs

View workflow job for this annotation

GitHub Actions / build-test-stable (ubuntu-latest, net6.0)

Possible null reference argument for parameter 'services' in 'MeterProviderBuilderBase.MeterProviderBuilderBase(IServiceCollection services)'.

Check failure on line 74 in src/OpenTelemetry.Extensions.Hosting/OpenTelemetryMetricsBuilderExtensions.cs

View workflow job for this annotation

GitHub Actions / build-test-stable (ubuntu-latest, net6.0)

Possible null reference argument for parameter 'services' in 'MeterProviderBuilderBase.MeterProviderBuilderBase(IServiceCollection services)'.

Check failure on line 74 in src/OpenTelemetry.Extensions.Hosting/OpenTelemetryMetricsBuilderExtensions.cs

View workflow job for this annotation

GitHub Actions / build-test-stable (ubuntu-latest, net7.0)

Possible null reference argument for parameter 'services' in 'MeterProviderBuilderBase.MeterProviderBuilderBase(IServiceCollection services)'.

Check failure on line 74 in src/OpenTelemetry.Extensions.Hosting/OpenTelemetryMetricsBuilderExtensions.cs

View workflow job for this annotation

GitHub Actions / build-test-stable (ubuntu-latest, net7.0)

Possible null reference argument for parameter 'services' in 'MeterProviderBuilderBase.MeterProviderBuilderBase(IServiceCollection services)'.

Check failure on line 74 in src/OpenTelemetry.Extensions.Hosting/OpenTelemetryMetricsBuilderExtensions.cs

View workflow job for this annotation

GitHub Actions / build-test-stable (ubuntu-latest, net7.0)

Possible null reference argument for parameter 'services' in 'MeterProviderBuilderBase.MeterProviderBuilderBase(IServiceCollection services)'.

Check failure on line 74 in src/OpenTelemetry.Extensions.Hosting/OpenTelemetryMetricsBuilderExtensions.cs

View workflow job for this annotation

GitHub Actions / build-test-stable (ubuntu-latest, net7.0)

Possible null reference argument for parameter 'services' in 'MeterProviderBuilderBase.MeterProviderBuilderBase(IServiceCollection services)'.

Check failure on line 74 in src/OpenTelemetry.Extensions.Hosting/OpenTelemetryMetricsBuilderExtensions.cs

View workflow job for this annotation

GitHub Actions / build-test-experimental (ubuntu-latest, net6.0)

Possible null reference argument for parameter 'services' in 'MeterProviderBuilderBase.MeterProviderBuilderBase(IServiceCollection services)'.

Check failure on line 74 in src/OpenTelemetry.Extensions.Hosting/OpenTelemetryMetricsBuilderExtensions.cs

View workflow job for this annotation

GitHub Actions / build-test-experimental (ubuntu-latest, net6.0)

Possible null reference argument for parameter 'services' in 'MeterProviderBuilderBase.MeterProviderBuilderBase(IServiceCollection services)'.

Check failure on line 74 in src/OpenTelemetry.Extensions.Hosting/OpenTelemetryMetricsBuilderExtensions.cs

View workflow job for this annotation

GitHub Actions / build-test-experimental (ubuntu-latest, net6.0)

Possible null reference argument for parameter 'services' in 'MeterProviderBuilderBase.MeterProviderBuilderBase(IServiceCollection services)'.

Check failure on line 74 in src/OpenTelemetry.Extensions.Hosting/OpenTelemetryMetricsBuilderExtensions.cs

View workflow job for this annotation

GitHub Actions / build-test-experimental (ubuntu-latest, net6.0)

Possible null reference argument for parameter 'services' in 'MeterProviderBuilderBase.MeterProviderBuilderBase(IServiceCollection services)'.

Check failure on line 74 in src/OpenTelemetry.Extensions.Hosting/OpenTelemetryMetricsBuilderExtensions.cs

View workflow job for this annotation

GitHub Actions / build-test-experimental (ubuntu-latest, net8.0)

Possible null reference argument for parameter 'services' in 'MeterProviderBuilderBase.MeterProviderBuilderBase(IServiceCollection services)'.

Check failure on line 74 in src/OpenTelemetry.Extensions.Hosting/OpenTelemetryMetricsBuilderExtensions.cs

View workflow job for this annotation

GitHub Actions / build-test-experimental (ubuntu-latest, net8.0)

Possible null reference argument for parameter 'services' in 'MeterProviderBuilderBase.MeterProviderBuilderBase(IServiceCollection services)'.

Check failure on line 74 in src/OpenTelemetry.Extensions.Hosting/OpenTelemetryMetricsBuilderExtensions.cs

View workflow job for this annotation

GitHub Actions / build-test-experimental (ubuntu-latest, net8.0)

Possible null reference argument for parameter 'services' in 'MeterProviderBuilderBase.MeterProviderBuilderBase(IServiceCollection services)'.

Check failure on line 74 in src/OpenTelemetry.Extensions.Hosting/OpenTelemetryMetricsBuilderExtensions.cs

View workflow job for this annotation

GitHub Actions / build-test-experimental (ubuntu-latest, net8.0)

Possible null reference argument for parameter 'services' in 'MeterProviderBuilderBase.MeterProviderBuilderBase(IServiceCollection services)'.

Check failure on line 74 in src/OpenTelemetry.Extensions.Hosting/OpenTelemetryMetricsBuilderExtensions.cs

View workflow job for this annotation

GitHub Actions / build-test-stable (ubuntu-latest, net8.0)

Possible null reference argument for parameter 'services' in 'MeterProviderBuilderBase.MeterProviderBuilderBase(IServiceCollection services)'.

Check failure on line 74 in src/OpenTelemetry.Extensions.Hosting/OpenTelemetryMetricsBuilderExtensions.cs

View workflow job for this annotation

GitHub Actions / build-test-stable (ubuntu-latest, net8.0)

Possible null reference argument for parameter 'services' in 'MeterProviderBuilderBase.MeterProviderBuilderBase(IServiceCollection services)'.

Check failure on line 74 in src/OpenTelemetry.Extensions.Hosting/OpenTelemetryMetricsBuilderExtensions.cs

View workflow job for this annotation

GitHub Actions / build-test-stable (ubuntu-latest, net8.0)

Possible null reference argument for parameter 'services' in 'MeterProviderBuilderBase.MeterProviderBuilderBase(IServiceCollection services)'.

Check failure on line 74 in src/OpenTelemetry.Extensions.Hosting/OpenTelemetryMetricsBuilderExtensions.cs

View workflow job for this annotation

GitHub Actions / build-test-stable (ubuntu-latest, net8.0)

Possible null reference argument for parameter 'services' in 'MeterProviderBuilderBase.MeterProviderBuilderBase(IServiceCollection services)'.

Check failure on line 74 in src/OpenTelemetry.Extensions.Hosting/OpenTelemetryMetricsBuilderExtensions.cs

View workflow job for this annotation

GitHub Actions / build-test-report (windows-latest)

Possible null reference argument for parameter 'services' in 'MeterProviderBuilderBase.MeterProviderBuilderBase(IServiceCollection services)'.

Check failure on line 74 in src/OpenTelemetry.Extensions.Hosting/OpenTelemetryMetricsBuilderExtensions.cs

View workflow job for this annotation

GitHub Actions / build-test-report (windows-latest)

Possible null reference argument for parameter 'services' in 'MeterProviderBuilderBase.MeterProviderBuilderBase(IServiceCollection services)'.

Check failure on line 74 in src/OpenTelemetry.Extensions.Hosting/OpenTelemetryMetricsBuilderExtensions.cs

View workflow job for this annotation

GitHub Actions / build-test-report (windows-latest)

Possible null reference argument for parameter 'services' in 'MeterProviderBuilderBase.MeterProviderBuilderBase(IServiceCollection services)'.

Check failure on line 74 in src/OpenTelemetry.Extensions.Hosting/OpenTelemetryMetricsBuilderExtensions.cs

View workflow job for this annotation

GitHub Actions / build-test-report (windows-latest)

Possible null reference argument for parameter 'services' in 'MeterProviderBuilderBase.MeterProviderBuilderBase(IServiceCollection services)'.

Check failure on line 74 in src/OpenTelemetry.Extensions.Hosting/OpenTelemetryMetricsBuilderExtensions.cs

View workflow job for this annotation

GitHub Actions / build-test-stable

Possible null reference argument for parameter 'services' in 'MeterProviderBuilderBase.MeterProviderBuilderBase(IServiceCollection services)'.

Check failure on line 74 in src/OpenTelemetry.Extensions.Hosting/OpenTelemetryMetricsBuilderExtensions.cs

View workflow job for this annotation

GitHub Actions / build-test-stable

Possible null reference argument for parameter 'services' in 'MeterProviderBuilderBase.MeterProviderBuilderBase(IServiceCollection services)'.

Check failure on line 74 in src/OpenTelemetry.Extensions.Hosting/OpenTelemetryMetricsBuilderExtensions.cs

View workflow job for this annotation

GitHub Actions / build-test-stable (windows-latest, net8.0)

Possible null reference argument for parameter 'services' in 'MeterProviderBuilderBase.MeterProviderBuilderBase(IServiceCollection services)'.

Check failure on line 74 in src/OpenTelemetry.Extensions.Hosting/OpenTelemetryMetricsBuilderExtensions.cs

View workflow job for this annotation

GitHub Actions / build-test-stable (windows-latest, net8.0)

Possible null reference argument for parameter 'services' in 'MeterProviderBuilderBase.MeterProviderBuilderBase(IServiceCollection services)'.

Check failure on line 74 in src/OpenTelemetry.Extensions.Hosting/OpenTelemetryMetricsBuilderExtensions.cs

View workflow job for this annotation

GitHub Actions / build-test-stable (windows-latest, net8.0)

Possible null reference argument for parameter 'services' in 'MeterProviderBuilderBase.MeterProviderBuilderBase(IServiceCollection services)'.

Check failure on line 74 in src/OpenTelemetry.Extensions.Hosting/OpenTelemetryMetricsBuilderExtensions.cs

View workflow job for this annotation

GitHub Actions / build-test-stable (windows-latest, net8.0)

Possible null reference argument for parameter 'services' in 'MeterProviderBuilderBase.MeterProviderBuilderBase(IServiceCollection services)'.

Check failure on line 74 in src/OpenTelemetry.Extensions.Hosting/OpenTelemetryMetricsBuilderExtensions.cs

View workflow job for this annotation

GitHub Actions / build-test-experimental (windows-latest, net7.0)

Possible null reference argument for parameter 'services' in 'MeterProviderBuilderBase.MeterProviderBuilderBase(IServiceCollection services)'.

Check failure on line 74 in src/OpenTelemetry.Extensions.Hosting/OpenTelemetryMetricsBuilderExtensions.cs

View workflow job for this annotation

GitHub Actions / build-test-experimental (windows-latest, net7.0)

Possible null reference argument for parameter 'services' in 'MeterProviderBuilderBase.MeterProviderBuilderBase(IServiceCollection services)'.

Check failure on line 74 in src/OpenTelemetry.Extensions.Hosting/OpenTelemetryMetricsBuilderExtensions.cs

View workflow job for this annotation

GitHub Actions / build-test-experimental (windows-latest, net7.0)

Possible null reference argument for parameter 'services' in 'MeterProviderBuilderBase.MeterProviderBuilderBase(IServiceCollection services)'.

Check failure on line 74 in src/OpenTelemetry.Extensions.Hosting/OpenTelemetryMetricsBuilderExtensions.cs

View workflow job for this annotation

GitHub Actions / build-test-experimental (windows-latest, net7.0)

Possible null reference argument for parameter 'services' in 'MeterProviderBuilderBase.MeterProviderBuilderBase(IServiceCollection services)'.

Check failure on line 74 in src/OpenTelemetry.Extensions.Hosting/OpenTelemetryMetricsBuilderExtensions.cs

View workflow job for this annotation

GitHub Actions / build-test-experimental (windows-latest, net8.0)

Possible null reference argument for parameter 'services' in 'MeterProviderBuilderBase.MeterProviderBuilderBase(IServiceCollection services)'.

Check failure on line 74 in src/OpenTelemetry.Extensions.Hosting/OpenTelemetryMetricsBuilderExtensions.cs

View workflow job for this annotation

GitHub Actions / build-test-experimental (windows-latest, net8.0)

Possible null reference argument for parameter 'services' in 'MeterProviderBuilderBase.MeterProviderBuilderBase(IServiceCollection services)'.

Check failure on line 74 in src/OpenTelemetry.Extensions.Hosting/OpenTelemetryMetricsBuilderExtensions.cs

View workflow job for this annotation

GitHub Actions / build-test-experimental (windows-latest, net8.0)

Possible null reference argument for parameter 'services' in 'MeterProviderBuilderBase.MeterProviderBuilderBase(IServiceCollection services)'.

Check failure on line 74 in src/OpenTelemetry.Extensions.Hosting/OpenTelemetryMetricsBuilderExtensions.cs

View workflow job for this annotation

GitHub Actions / build-test-experimental (windows-latest, net8.0)

Possible null reference argument for parameter 'services' in 'MeterProviderBuilderBase.MeterProviderBuilderBase(IServiceCollection services)'.

Check failure on line 74 in src/OpenTelemetry.Extensions.Hosting/OpenTelemetryMetricsBuilderExtensions.cs

View workflow job for this annotation

GitHub Actions / build-test-experimental (windows-latest, net6.0)

Possible null reference argument for parameter 'services' in 'MeterProviderBuilderBase.MeterProviderBuilderBase(IServiceCollection services)'.

Check failure on line 74 in src/OpenTelemetry.Extensions.Hosting/OpenTelemetryMetricsBuilderExtensions.cs

View workflow job for this annotation

GitHub Actions / build-test-experimental (windows-latest, net6.0)

Possible null reference argument for parameter 'services' in 'MeterProviderBuilderBase.MeterProviderBuilderBase(IServiceCollection services)'.

Check failure on line 74 in src/OpenTelemetry.Extensions.Hosting/OpenTelemetryMetricsBuilderExtensions.cs

View workflow job for this annotation

GitHub Actions / build-test-experimental (windows-latest, net6.0)

Possible null reference argument for parameter 'services' in 'MeterProviderBuilderBase.MeterProviderBuilderBase(IServiceCollection services)'.

Check failure on line 74 in src/OpenTelemetry.Extensions.Hosting/OpenTelemetryMetricsBuilderExtensions.cs

View workflow job for this annotation

GitHub Actions / build-test-experimental (windows-latest, net6.0)

Possible null reference argument for parameter 'services' in 'MeterProviderBuilderBase.MeterProviderBuilderBase(IServiceCollection services)'.

Check failure on line 74 in src/OpenTelemetry.Extensions.Hosting/OpenTelemetryMetricsBuilderExtensions.cs

View workflow job for this annotation

GitHub Actions / build-test-stable (windows-latest, net6.0)

Possible null reference argument for parameter 'services' in 'MeterProviderBuilderBase.MeterProviderBuilderBase(IServiceCollection services)'.

Check failure on line 74 in src/OpenTelemetry.Extensions.Hosting/OpenTelemetryMetricsBuilderExtensions.cs

View workflow job for this annotation

GitHub Actions / build-test-stable (windows-latest, net6.0)

Possible null reference argument for parameter 'services' in 'MeterProviderBuilderBase.MeterProviderBuilderBase(IServiceCollection services)'.

Check failure on line 74 in src/OpenTelemetry.Extensions.Hosting/OpenTelemetryMetricsBuilderExtensions.cs

View workflow job for this annotation

GitHub Actions / build-test-stable (windows-latest, net6.0)

Possible null reference argument for parameter 'services' in 'MeterProviderBuilderBase.MeterProviderBuilderBase(IServiceCollection services)'.

Check failure on line 74 in src/OpenTelemetry.Extensions.Hosting/OpenTelemetryMetricsBuilderExtensions.cs

View workflow job for this annotation

GitHub Actions / build-test-stable (windows-latest, net6.0)

Possible null reference argument for parameter 'services' in 'MeterProviderBuilderBase.MeterProviderBuilderBase(IServiceCollection services)'.

Check failure on line 74 in src/OpenTelemetry.Extensions.Hosting/OpenTelemetryMetricsBuilderExtensions.cs

View workflow job for this annotation

GitHub Actions / build-test-experimental (windows-latest, net462)

Possible null reference argument for parameter 'services' in 'MeterProviderBuilderBase.MeterProviderBuilderBase(IServiceCollection services)'.

Check failure on line 74 in src/OpenTelemetry.Extensions.Hosting/OpenTelemetryMetricsBuilderExtensions.cs

View workflow job for this annotation

GitHub Actions / build-test-experimental (windows-latest, net462)

Possible null reference argument for parameter 'services' in 'MeterProviderBuilderBase.MeterProviderBuilderBase(IServiceCollection services)'.

Check failure on line 74 in src/OpenTelemetry.Extensions.Hosting/OpenTelemetryMetricsBuilderExtensions.cs

View workflow job for this annotation

GitHub Actions / build-test-experimental (windows-latest, net462)

Possible null reference argument for parameter 'services' in 'MeterProviderBuilderBase.MeterProviderBuilderBase(IServiceCollection services)'.

Check failure on line 74 in src/OpenTelemetry.Extensions.Hosting/OpenTelemetryMetricsBuilderExtensions.cs

View workflow job for this annotation

GitHub Actions / build-test-experimental (windows-latest, net462)

Possible null reference argument for parameter 'services' in 'MeterProviderBuilderBase.MeterProviderBuilderBase(IServiceCollection services)'.

Check failure on line 74 in src/OpenTelemetry.Extensions.Hosting/OpenTelemetryMetricsBuilderExtensions.cs

View workflow job for this annotation

GitHub Actions / build-test-experimental

Possible null reference argument for parameter 'services' in 'MeterProviderBuilderBase.MeterProviderBuilderBase(IServiceCollection services)'.

Check failure on line 74 in src/OpenTelemetry.Extensions.Hosting/OpenTelemetryMetricsBuilderExtensions.cs

View workflow job for this annotation

GitHub Actions / build-test-experimental

Possible null reference argument for parameter 'services' in 'MeterProviderBuilderBase.MeterProviderBuilderBase(IServiceCollection services)'.

Check failure on line 74 in src/OpenTelemetry.Extensions.Hosting/OpenTelemetryMetricsBuilderExtensions.cs

View workflow job for this annotation

GitHub Actions / build-test-stable (windows-latest, net462)

Possible null reference argument for parameter 'services' in 'MeterProviderBuilderBase.MeterProviderBuilderBase(IServiceCollection services)'.

Check failure on line 74 in src/OpenTelemetry.Extensions.Hosting/OpenTelemetryMetricsBuilderExtensions.cs

View workflow job for this annotation

GitHub Actions / build-test-stable (windows-latest, net462)

Possible null reference argument for parameter 'services' in 'MeterProviderBuilderBase.MeterProviderBuilderBase(IServiceCollection services)'.

Check failure on line 74 in src/OpenTelemetry.Extensions.Hosting/OpenTelemetryMetricsBuilderExtensions.cs

View workflow job for this annotation

GitHub Actions / build-test-stable (windows-latest, net462)

Possible null reference argument for parameter 'services' in 'MeterProviderBuilderBase.MeterProviderBuilderBase(IServiceCollection services)'.

Check failure on line 74 in src/OpenTelemetry.Extensions.Hosting/OpenTelemetryMetricsBuilderExtensions.cs

View workflow job for this annotation

GitHub Actions / build-test-stable (windows-latest, net462)

Possible null reference argument for parameter 'services' in 'MeterProviderBuilderBase.MeterProviderBuilderBase(IServiceCollection services)'.

Check failure on line 74 in src/OpenTelemetry.Extensions.Hosting/OpenTelemetryMetricsBuilderExtensions.cs

View workflow job for this annotation

GitHub Actions / build-test-stable (windows-latest, net7.0)

Possible null reference argument for parameter 'services' in 'MeterProviderBuilderBase.MeterProviderBuilderBase(IServiceCollection services)'.

Check failure on line 74 in src/OpenTelemetry.Extensions.Hosting/OpenTelemetryMetricsBuilderExtensions.cs

View workflow job for this annotation

GitHub Actions / build-test-stable (windows-latest, net7.0)

Possible null reference argument for parameter 'services' in 'MeterProviderBuilderBase.MeterProviderBuilderBase(IServiceCollection services)'.

Check failure on line 74 in src/OpenTelemetry.Extensions.Hosting/OpenTelemetryMetricsBuilderExtensions.cs

View workflow job for this annotation

GitHub Actions / build-test-stable (windows-latest, net7.0)

Possible null reference argument for parameter 'services' in 'MeterProviderBuilderBase.MeterProviderBuilderBase(IServiceCollection services)'.

Check failure on line 74 in src/OpenTelemetry.Extensions.Hosting/OpenTelemetryMetricsBuilderExtensions.cs

View workflow job for this annotation

GitHub Actions / build-test-stable (windows-latest, net7.0)

Possible null reference argument for parameter 'services' in 'MeterProviderBuilderBase.MeterProviderBuilderBase(IServiceCollection services)'.

metricsBuilder.Services.TryAddEnumerable(
services.TryAddEnumerable(
ServiceDescriptor.Singleton<IMetricsListener, OpenTelemetryMetricsListener>());

configure(builder);

return metricsBuilder;
}
}
Loading