Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Instrumentation.Http] follow up from previous pr #4919

Merged
merged 4 commits into from
Oct 6, 2023

Conversation

TimothyMothra
Copy link
Contributor

Follow up to #4870

Changes

  • update changelog to mention new metrics are available for both HttpClient and HttpWebRequest
  • update Readme to describe both new metrics http.client.duration and http.client.request.duration.
  • update unit test.
    • remove extra IF statement.
    • assert units. (s and ms).
    • assert histogram bounds.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@TimothyMothra TimothyMothra requested a review from a team October 4, 2023 22:53
@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Merging #4919 (d8df973) into main (d4d5122) will increase coverage by 0.01%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4919      +/-   ##
==========================================
+ Coverage   83.28%   83.30%   +0.01%     
==========================================
  Files         295      295              
  Lines       12324    12324              
==========================================
+ Hits        10264    10266       +2     
+ Misses       2060     2058       -2     
Flag Coverage Δ
unittests 83.30% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes

@@ -31,7 +31,8 @@
* [http-metrics](https://github.com/open-telemetry/semantic-conventions/blob/2bad9afad58fbd6b33cc683d1ad1f006e35e4a5d/docs/http/http-metrics.md)

* Added support for publishing `http.client.duration` &
`http.client.request.duration` metrics on .NET Framework
`http.client.request.duration` metrics on .NET Framework.
This supports `HttpClient` and `HttpWebRequest`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems redundant to me because everything in this library w.r.t. .NET Framework works for both HttpClient & HttpWebRequest.

This is an [Instrumentation
Library](https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/glossary.md#instrumentation-library),
which instruments
[System.Net.Http.HttpClient](https://docs.microsoft.com/dotnet/api/system.net.http.httpclient)
and
[System.Net.HttpWebRequest](https://docs.microsoft.com/dotnet/api/system.net.httpwebrequest)
and collects metrics and traces about outgoing HTTP requests.

I would say we should only mention it if it didn't work for one or the other for some reason.

Not a blocker for me, just sayin' 🤔

Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -2,8 +2,8 @@

## Unreleased

* Introduced a new metric, `http.client.request.duration` measured in seconds.
The OTel SDK
* Introduced a new metric for `HttpClient`, `http.client.request.duration`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Introduced a new metric for `HttpClient`, `http.client.request.duration`
* Introduced a new metric for `HttpClient` named `http.client.request.duration` which is measured in seconds

@utpilla utpilla merged commit be45aab into open-telemetry:main Oct 6, 2023
67 checks passed
@TimothyMothra TimothyMothra deleted the 4870_followup branch October 26, 2023 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants