-
Notifications
You must be signed in to change notification settings - Fork 859
[integration test] otlp log exporter #4854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
utpilla
merged 9 commits into
open-telemetry:main
from
vishweshbankwar:vibankwa/add-otlp-log-integration-test
Sep 18, 2023
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
4d47ea1
[integration test] otlp log exporter
2ee815d
Merge branch 'main' into vibankwa/add-otlp-log-integration-test
vishweshbankwar d1da7ea
fix example
f191a81
Merge branch 'vibankwa/add-otlp-log-integration-test' of https://gith…
605b1d7
Merge branch 'main' into vibankwa/add-otlp-log-integration-test
vishweshbankwar 12c2436
Merge branch 'vibankwa/add-otlp-log-integration-test' of https://gith…
639685c
address feedback
24f01e6
refactor
cafcb0c
Merge branch 'main' into vibankwa/add-otlp-log-integration-test
utpilla File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -59,49 +59,46 @@ public static OpenTelemetryLoggerOptions AddOtlpExporter( | |
|
|
||
| configureExporterAndProcessor?.Invoke(exporterOptions, processorOptions); | ||
|
|
||
| return AddOtlpLogExporterInternal( | ||
| loggerOptions, | ||
| exporterOptions: exporterOptions, | ||
| processorOptions: processorOptions); | ||
| return loggerOptions.AddProcessor(BuildOtlpLogExporter(exporterOptions, processorOptions)); | ||
| } | ||
|
|
||
| private static OpenTelemetryLoggerOptions AddOtlpExporterInternal( | ||
| OpenTelemetryLoggerOptions loggerOptions, | ||
| Action<OtlpExporterOptions> configure) | ||
| { | ||
| var exporterOptions = new OtlpExporterOptions(); | ||
|
|
||
| configure?.Invoke(exporterOptions); | ||
|
|
||
| return AddOtlpLogExporterInternal( | ||
| loggerOptions, | ||
| exporterOptions: exporterOptions, | ||
| processorOptions: new()); | ||
| } | ||
|
|
||
| private static OpenTelemetryLoggerOptions AddOtlpLogExporterInternal( | ||
| OpenTelemetryLoggerOptions loggerOptions, | ||
| internal static BaseProcessor<LogRecord> BuildOtlpLogExporter( | ||
| OtlpExporterOptions exporterOptions, | ||
| LogRecordExportProcessorOptions processorOptions) | ||
| LogRecordExportProcessorOptions processorOptions, | ||
| Func<BaseExporter<LogRecord>, BaseExporter<LogRecord>> configureExporterInstance = null) | ||
| { | ||
| var otlpExporter = new OtlpLogExporter(exporterOptions); | ||
| BaseExporter<LogRecord> otlpExporter = new OtlpLogExporter(exporterOptions); | ||
|
|
||
| if (configureExporterInstance != null) | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Add a comment that this option is only used by tests. |
||
| { | ||
| otlpExporter = configureExporterInstance(otlpExporter); | ||
| } | ||
|
|
||
| if (processorOptions.ExportProcessorType == ExportProcessorType.Simple) | ||
| { | ||
| loggerOptions.AddProcessor(new SimpleLogRecordExportProcessor(otlpExporter)); | ||
| return new SimpleLogRecordExportProcessor(otlpExporter); | ||
| } | ||
| else | ||
| { | ||
| var batchOptions = processorOptions.BatchExportProcessorOptions; | ||
|
|
||
| loggerOptions.AddProcessor(new BatchLogRecordExportProcessor( | ||
| return new BatchLogRecordExportProcessor( | ||
| otlpExporter, | ||
| batchOptions.MaxQueueSize, | ||
| batchOptions.ScheduledDelayMilliseconds, | ||
| batchOptions.ExporterTimeoutMilliseconds, | ||
| batchOptions.MaxExportBatchSize)); | ||
| batchOptions.MaxExportBatchSize); | ||
| } | ||
| } | ||
|
|
||
| private static OpenTelemetryLoggerOptions AddOtlpExporterInternal( | ||
| OpenTelemetryLoggerOptions loggerOptions, | ||
| Action<OtlpExporterOptions> configure) | ||
| { | ||
| var exporterOptions = new OtlpExporterOptions(); | ||
|
|
||
| configure?.Invoke(exporterOptions); | ||
|
|
||
| return loggerOptions; | ||
| return loggerOptions.AddProcessor(BuildOtlpLogExporter(exporterOptions, new())); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Simplify this by using
configureExporterInstance?.Invoke(otlpExporter).