Skip to content

Conversation

@pengweiqhca
Copy link
Contributor

Fixes #4813

Changes

Add OtlpExporterOptions.HttpHandlerFactory property to get a HttpHandler.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@pengweiqhca pengweiqhca requested a review from a team August 30, 2023 14:09
@vishweshbankwar
Copy link
Member

@pengweiqhca Thanks for the PR. We are currently working on releasing 1.6.0. We will review the issue and PR sometime next week. Thanks for your patience.

@AB027PS
Copy link
Contributor

AB027PS commented Sep 13, 2023

This also fixes #4771.

Copy link
Member

@vishweshbankwar vishweshbankwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pengweiqhca Could you please provide more detailed steps for repro on this (Please update the issue)? Once we have a repro, we will then explore the possible solution.

@jviau
Copy link

jviau commented Sep 14, 2023

I'd recommend not exposing HTTP at all in the options. Instead allow for a Grpc.Core.Api.CallInvoker to be provided. This will work with both Grpc.Net.Client as well as Grpc.Core. No if-def'ing needed. It will give the most flexibility with how a user provides their desired gRPC connection - including creating a call invoker with all the custom HttpClient / HttpHandler under the hood as needed.

@pengweiqhca
Copy link
Contributor Author

pengweiqhca commented Sep 15, 2023

@vishweshbankwar I has change the repro.
@jviau Grpc.Core.Api.CallInvoker is a good idea, it is possible for log, trace, and metrics to use the same Grpc channel.

@pengweiqhca pengweiqhca changed the title Grpc exporter support custom HttpHandler. Most flexibility provides gRPC connection Sep 16, 2023
@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or Pushing will instruct the bot to automatically remove the label. This bot runs once per day.

@github-actions github-actions bot added the Stale Issues and pull requests which have been flagged for closing due to inactivity label Sep 23, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 1, 2023

Closed as inactive. Feel free to reopen if this PR is still being worked on.

@github-actions github-actions bot closed this Oct 1, 2023
@cvi-mft
Copy link

cvi-mft commented May 21, 2024

Why was this closed?

@alexander-kucherov
Copy link

Why this PR was closed? I also need this changes

@alexander-kucherov
Copy link

Any news ?

@CodeBlanch
Copy link
Member

@alexander-kucherov We're currently working to remove the grpc library dependencies from the OtlpExporter. This particular API won't be possible to expose in that design. I think the best thing to do is open an issue with what you want to do, what the current blockers are. We can work to expose something once the new design is ready (which should be soon: https://github.com/open-telemetry/opentelemetry-dotnet/milestone/44).

AFAIK @rajkumar-rangaraj's plan at the moment is everything will use HttpClient so it may be possible to do what you need via the existing APIs/extension points once the work is complete?

@pengweiqhca pengweiqhca deleted the factory branch May 21, 2025 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Stale Issues and pull requests which have been flagged for closing due to inactivity

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Grpc exporter doesn't follow dns change.

7 participants