-
Notifications
You must be signed in to change notification settings - Fork 859
Most flexibility provides gRPC connection #4815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@pengweiqhca Thanks for the PR. We are currently working on releasing 1.6.0. We will review the issue and PR sometime next week. Thanks for your patience. |
|
This also fixes #4771. |
vishweshbankwar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pengweiqhca Could you please provide more detailed steps for repro on this (Please update the issue)? Once we have a repro, we will then explore the possible solution.
|
I'd recommend not exposing HTTP at all in the options. Instead allow for a |
|
@vishweshbankwar I has change the repro. |
|
This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or Pushing will instruct the bot to automatically remove the label. This bot runs once per day. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
|
Why was this closed? |
|
Why this PR was closed? I also need this changes |
|
Any news ? |
|
@alexander-kucherov We're currently working to remove the grpc library dependencies from the OtlpExporter. This particular API won't be possible to expose in that design. I think the best thing to do is open an issue with what you want to do, what the current blockers are. We can work to expose something once the new design is ready (which should be soon: https://github.com/open-telemetry/opentelemetry-dotnet/milestone/44). AFAIK @rajkumar-rangaraj's plan at the moment is everything will use |
Fixes #4813
Changes
Add
OtlpExporterOptions.HttpHandlerFactoryproperty to get a HttpHandler.Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changes