Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update protos to v0.19.0 #3535

Merged
merged 2 commits into from
Aug 4, 2022

Conversation

alanwest
Copy link
Member

@alanwest alanwest commented Aug 4, 2022

With the addition of option csharp_namespace = "OpenTelemetry.Proto.* to the proto files in v0.19.0 I find the namespaces much more soothing to the 👀.

@alanwest alanwest requested a review from a team August 4, 2022 00:06
@codecov
Copy link

codecov bot commented Aug 4, 2022

Codecov Report

Merging #3535 (e860388) into main (21d185a) will decrease coverage by 0.27%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3535      +/-   ##
==========================================
- Coverage   86.82%   86.55%   -0.28%     
==========================================
  Files         275      275              
  Lines        9949     9949              
==========================================
- Hits         8638     8611      -27     
- Misses       1311     1338      +27     
Impacted Files Coverage Δ
...metryProtocol/Implementation/ActivityExtensions.cs 91.20% <ø> (-3.30%) ⬇️
...ementation/ExportClient/OtlpGrpcLogExportClient.cs 78.57% <ø> (ø)
...tation/ExportClient/OtlpGrpcMetricsExportClient.cs 78.57% <ø> (ø)
...entation/ExportClient/OtlpGrpcTraceExportClient.cs 35.71% <ø> (-42.86%) ⬇️
...ementation/ExportClient/OtlpHttpLogExportClient.cs 0.00% <ø> (ø)
...tation/ExportClient/OtlpHttpMetricsExportClient.cs 62.50% <ø> (ø)
...entation/ExportClient/OtlpHttpTraceExportClient.cs 87.50% <ø> (ø)
...etryProtocol/Implementation/LogRecordExtensions.cs 87.95% <ø> (ø)
...tryProtocol/Implementation/MetricItemExtensions.cs 93.83% <ø> (ø)
...Protocol/Implementation/OtlpKeyValueTransformer.cs 85.71% <ø> (ø)
... and 12 more

@cijothomas cijothomas merged commit 2b6a3b0 into open-telemetry:main Aug 4, 2022
@alanwest alanwest deleted the alanwest/0.19.0-protos branch September 30, 2022 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants