Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tracing): deprecate use of B3 propagator class from API package - use Extensions.Propagators package instead #3289

Merged
merged 13 commits into from
May 31, 2022
Merged

feat(tracing): deprecate use of B3 propagator class from API package - use Extensions.Propagators package instead #3289

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
dc3081c
deprecate use of B3 propagator from API package
dmpe May 18, 2022
48d70d5
force lf
dmpe May 18, 2022
4db6b0a
Merge remote-tracking branch 'origin/main' into deprec_b3_api
dmpe May 21, 2022
96e9e9a
Merge branch 'main' into deprec_b3_api
dmpe May 25, 2022
87e023f
Merge branch 'main' into deprec_b3_api
dmpe May 26, 2022
24b55b8
improve deprecated information
dmpe May 26, 2022
e6ae5dc
Remove instead
dmpe May 26, 2022
2f30c05
Update src/OpenTelemetry.Api/Context/Propagation/B3Propagator.cs
dmpe May 26, 2022
ac9d305
Merge branch 'main' into deprec_b3_api
dmpe May 28, 2022
a4c47cd
add obsolete messages everywhere
dmpe May 28, 2022
8c4ec8e
add obsolete messages everywhere - new
dmpe May 28, 2022
d2a6b05
update changelog
dmpe May 28, 2022
365b67a
stage
dmpe May 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add obsolete messages everywhere - new
  • Loading branch information
@dmpe
dmpe committed May 28, 2022
commit 8c4ec8e7dbc61efc6a2e020b6316ef914165bbfb
4 changes: 2 additions & 2 deletions src/OpenTelemetry.Api/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@

## Unreleased

* `B3Propagator` class has been deprecated and moved as is to a new
`OpenTelemetry.Extensions.Propagators` package.
* `B3Propagator` class from `OpenTelemetry.Extensions.Propagators` namespace has been deprecated and
moved as is to a new `OpenTelemetry.Extensions.Propagators` package.
It will be removed in the next major release, see issue [#3259](https://github.com/open-telemetry/opentelemetry-dotnet/issues/3259)

## 1.3.0-beta.2
Expand Down
8 changes: 4 additions & 4 deletions src/OpenTelemetry.Api/Context/Propagation/B3Propagator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ public sealed class B3Propagator : TextMapPropagator
/// <summary>
/// Initializes a new instance of the <see cref="B3Propagator"/> class.
/// </summary>
[Obsolete("Use B3Propagator contructor from OpenTelemetry.Extensions.Propagators namespace, shipped as part of OpenTelemetry.Extensions.Propagators package.")]
[Obsolete("Use B3Propagator class from OpenTelemetry.Extensions.Propagators namespace, shipped as part of OpenTelemetry.Extensions.Propagators package.")]
public B3Propagator()
: this(false)
{
Expand All @@ -70,7 +70,7 @@ public B3Propagator()
/// Initializes a new instance of the <see cref="B3Propagator"/> class.
/// </summary>
/// <param name="singleHeader">Determines whether to use single or multiple headers when extracting or injecting span context.</param>
[Obsolete("Use B3Propagator contructor from OpenTelemetry.Extensions.Propagators namespace, shipped as part of OpenTelemetry.Extensions.Propagators package.")]
[Obsolete("Use B3Propagator class from OpenTelemetry.Extensions.Propagators namespace, shipped as part of OpenTelemetry.Extensions.Propagators package.")]
public B3Propagator(bool singleHeader)
{
this.singleHeader = singleHeader;
Expand All @@ -80,7 +80,7 @@ public B3Propagator(bool singleHeader)
public override ISet<string> Fields => AllFields;

/// <inheritdoc/>
[Obsolete("Use Extract function from OpenTelemetry.Extensions.Propagators namespace, shipped as part of OpenTelemetry.Extensions.Propagators package.")]
[Obsolete("Use B3Propagator class from OpenTelemetry.Extensions.Propagators namespace, shipped as part of OpenTelemetry.Extensions.Propagators package.")]
#pragma warning disable CS0809 // Obsolete member overrides non-obsolete member
public override PropagationContext Extract<T>(PropagationContext context, T carrier, Func<T, string, IEnumerable<string>> getter)
#pragma warning restore CS0809 // Obsolete member overrides non-obsolete member
Expand Down Expand Up @@ -114,7 +114,7 @@ public override PropagationContext Extract<T>(PropagationContext context, T carr
}

/// <inheritdoc/>
[Obsolete("Use Inject function from OpenTelemetry.Extensions.Propagators namespace, shipped as part of OpenTelemetry.Extensions.Propagators package.")]
[Obsolete("Use B3Propagator class from OpenTelemetry.Extensions.Propagators namespace, shipped as part of OpenTelemetry.Extensions.Propagators package.")]
#pragma warning disable CS0809 // Obsolete member overrides non-obsolete member
public override void Inject<T>(PropagationContext context, T carrier, Action<T, string, string> setter)
#pragma warning restore CS0809 // Obsolete member overrides non-obsolete member
Expand Down