Handle exceptions when transforming array values

src/OpenTelemetry.Exporter.OpenTelemetryProtocol/Implementation/OtlpKeyValueTransformer.cs

@@ -73,8 +73,15 @@ protected override OtlpCommon.AnyValue TransformArrayValue(Array array)
 
             foreach (var item in array)
             {
-                var value = item != null ? this.TransformValue(item) : new OtlpCommon.AnyValue();
-                arrayValue.Values.Add(value);
+                try
+                {
+                    var value = item != null ? this.TransformValue(item) : new OtlpCommon.AnyValue();
+                    arrayValue.Values.Add(value);
+                }
+                catch
+                {
+                    return null;
+                }
             }
 
             return new OtlpCommon.AnyValue { ArrayValue = arrayValue };

src/OpenTelemetry/Internal/TagAndValueTransformer.cs

@@ -41,7 +41,8 @@ public TValue TransformValue(object value)
             case double:
                 return this.TransformFloatingPointValue(Convert.ToDouble(value));
             default:
-                return default(TValue);
+                // This could throw an exception. The caller is expected to handle.
+                return this.TransformStringValue(value.ToString());
         }
     }
 

src/OpenTelemetry/Internal/TagTransformer.cs

@@ -28,7 +28,6 @@ public T TransformTag(KeyValuePair<string, object> tag)
             return default;
         }
 
-        T result = default;
         switch (tag.Value)
         {
             case char:
@@ -48,7 +47,16 @@ public T TransformTag(KeyValuePair<string, object> tag)
             case double:
                 return this.TransformFloatingPointTag(tag.Key, Convert.ToDouble(tag.Value));
             case Array array:
-                return this.TransformArrayTagInternal(tag.Key, array);
+                try
+                {
+                    return this.TransformArrayTagInternal(tag.Key, array);
+                }
+                catch
+                {
+                    // If ToString throws an exception then the tag is ignored.
+                    // OpenTelemetrySdkEventSource.Log.UnsupportedAttributeType(tag.Value.GetType().ToString(), tag.Key);
+                    return default(T);
+                }
 
             // All other types are converted to strings including the following
             // built-in value types:
@@ -59,22 +67,15 @@ public T TransformTag(KeyValuePair<string, object> tag)
             default:
                 try
                 {
-                    result = this.TransformStringTag(tag.Key, tag.Value.ToString());
+                    return this.TransformStringTag(tag.Key, tag.Value.ToString());
                 }
                 catch
                 {
                     // If ToString throws an exception then the tag is ignored.
+                    // OpenTelemetrySdkEventSource.Log.UnsupportedAttributeType(tag.Value.GetType().ToString(), tag.Key);
+                    return default(T);
                 }
-
-                break;
         }
-
-        // if (result == null)
-        // {
-        //     // OpenTelemetryProtocolExporterEventSource.Log.UnsupportedAttributeType(kvp.Value.GetType().ToString(), kvp.Key);
-        // }
-
-        return result;
     }
 
     protected abstract T TransformIntegralTag(string key, long value);