Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to the OTLP trace example #3141

Merged
merged 2 commits into from
Apr 6, 2022

Conversation

pjanotti
Copy link
Contributor

@pjanotti pjanotti commented Apr 5, 2022

Follow up to #3098 (comment)

  • Better defaults for the OTLP trace example
  • Add the http protocol to the collector config
  • Make example CLI commands copy and paste ready

cc @cijothomas

@pjanotti pjanotti requested a review from a team April 5, 2022 19:19
@codecov
Copy link

codecov bot commented Apr 5, 2022

Codecov Report

Merging #3141 (ea55a69) into main (62bb66a) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3141      +/-   ##
==========================================
+ Coverage   84.74%   84.76%   +0.02%     
==========================================
  Files         259      259              
  Lines        9228     9228              
==========================================
+ Hits         7820     7822       +2     
+ Misses       1408     1406       -2     
Impacted Files Coverage Δ
...emetry.Api/Internal/OpenTelemetryApiEventSource.cs 82.35% <0.00%> (+5.88%) ⬆️

pjanotti added 2 commits April 5, 2022 14:55
Better defaults and update collector and config

Remove test added by mistake on last commit
@pjanotti pjanotti force-pushed the otlp_examples_improvements branch from 536d9d8 to ea55a69 Compare April 5, 2022 22:15
@cijothomas cijothomas merged commit 950c616 into open-telemetry:main Apr 6, 2022
@pjanotti pjanotti deleted the otlp_examples_improvements branch April 6, 2022 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants