-
Notifications
You must be signed in to change notification settings - Fork 802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stale automation #2769
stale automation #2769
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2769 +/- ##
=======================================
Coverage 83.75% 83.75%
=======================================
Files 251 251
Lines 8864 8864
=======================================
Hits 7424 7424
Misses 1440 1440 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Adding few coins:
I think it's a fair number. If someone came back from vacation and decided to work on a stale PR, making it active again is like 0.01% of the total work.
I don't have a use case in mind at this moment.
That's a hard topic and here are my thoughts - having a 3-year active issue without any activity/updates is no better than not showing it in the default query. So I would vote for putting a 1-year policy - and we could learn from it and get feedback, never too late to make adjustments. BTW, it's "label" instead of "lable" 😸 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If someone came back from vacation and decided to work on a stale PR, making it active again is like 0.01% of the total work.
Coming back to work after vacation is the remaining 99.99%.
Fixes #2363
Changes
stale
stale
PRs will be closed after 7 additional days (14 total).Adding automation to close stale PRs.
This workflow was copied from https://github.com/open-telemetry/opentelemetry-specification/blob/main/.github/workflows/stale-pr.yaml
Outstanding Questions
Specification repo uses
repo-token: ${{ secrets.GITHUB_TOKEN }}
to provide someone's Personal Access Token to the stale automation. May not know if this is needed until we merge this and see it fail :)For context, this repo has 53 open PRs. With this setting, 46 would be identified as stale.
The specification repo exempts any PRs marked as
release:after-ga
. I don't see many PRs labeled here, but this is an option.Specification repo proposed 1 year but was unable to agree on a policy. If this is wanted, labels can be used to exempt specific issues.
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes