Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stale automation #2769

Merged
merged 5 commits into from
Jan 24, 2022
Merged

stale automation #2769

merged 5 commits into from
Jan 24, 2022

Conversation

TimothyMothra
Copy link
Contributor

@TimothyMothra TimothyMothra commented Jan 5, 2022

Fixes #2363

Changes

  • adding new Stale workflow to automatically close PRs
    • Issues are ignored
    • PRs older that 7 days will be tagged as stale
    • stale PRs will be closed after 7 additional days (14 total).

Adding automation to close stale PRs.
This workflow was copied from https://github.com/open-telemetry/opentelemetry-specification/blob/main/.github/workflows/stale-pr.yaml

Outstanding Questions

  • Does this repo require extra permissions for automation to make changes?
    Specification repo uses repo-token: ${{ secrets.GITHUB_TOKEN }} to provide someone's Personal Access Token to the stale automation. May not know if this is needed until we merge this and see it fail :)
  • The specification repo is using 7 days to mark PRs as stale, is this too aggressive for this repo?
    For context, this repo has 53 open PRs. With this setting, 46 would be identified as stale.
  • Should any PRs be exempt from stale?
    The specification repo exempts any PRs marked as release:after-ga. I don't see many PRs labeled here, but this is an option.
  • Should Issues be reviewed for stale?
    Specification repo proposed 1 year but was unable to agree on a policy. If this is wanted, labels can be used to exempt specific issues.

For significant contributions please make sure you have completed the following items:

  • Appropriate CHANGELOG.md updated for non-trivial changes
  • Design discussion issue #
  • Changes in public API reviewed

@TimothyMothra TimothyMothra requested a review from a team January 5, 2022 22:40
@codecov
Copy link

codecov bot commented Jan 5, 2022

Codecov Report

Merging #2769 (aca1fa7) into main (aad309b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2769   +/-   ##
=======================================
  Coverage   83.75%   83.75%           
=======================================
  Files         251      251           
  Lines        8864     8864           
=======================================
  Hits         7424     7424           
  Misses       1440     1440           

Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@reyang reyang added the infra Infra work - CI/CD, code coverage, linters label Jan 6, 2022
@reyang
Copy link
Member

reyang commented Jan 6, 2022

Adding few coins:

  • The specification repo is using 7 days to mark PRs as stale, is this too aggressive for this repo?

I think it's a fair number. If someone came back from vacation and decided to work on a stale PR, making it active again is like 0.01% of the total work.

  • Should any PRs be exempt from stale?

I don't have a use case in mind at this moment.

  • Should Issues be reviewed for stale?
    Specification repo proposed 1 year but was unable to agree on a policy. If this is wanted, lables can be used to exempt specific issues.

That's a hard topic and here are my thoughts - having a 3-year active issue without any activity/updates is no better than not showing it in the default query. So I would vote for putting a 1-year policy - and we could learn from it and get feedback, never too late to make adjustments.

BTW, it's "label" instead of "lable" 😸

Copy link
Member

@alanwest alanwest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If someone came back from vacation and decided to work on a stale PR, making it active again is like 0.01% of the total work.

Coming back to work after vacation is the remaining 99.99%.

@cijothomas cijothomas merged commit 9b27d70 into open-telemetry:main Jan 24, 2022
This was referenced Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra Infra work - CI/CD, code coverage, linters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatically mark/close stale issues/PRs
4 participants