Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZipkinExporter Stuck Batch Fix #1726

Merged
merged 10 commits into from
Jan 28, 2021
Merged

ZipkinExporter Stuck Batch Fix #1726

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
793d9a7
Fix batches growing indefinitely when ZipkinExporter can't make a con…
CodeBlanch Jan 27, 2021
6fe02d0
Tweaked DiagnosticSourceListener code.
CodeBlanch Jan 27, 2021
97a3312
Warning fixup.
CodeBlanch Jan 27, 2021
19b52fc
Merge branch 'master' into zipkin-exporter-fix
CodeBlanch Jan 27, 2021
09c2f91
Added Dispose to Batch<T>. BatchExportProcessor calls dispose on the …
CodeBlanch Jan 28, 2021
029d507
Code review.
CodeBlanch Jan 28, 2021
5073862
Code review.
CodeBlanch Jan 28, 2021
1584a6a
Merge branch 'main' into zipkin-exporter-fix
cijothomas Jan 28, 2021
66e301a
CHANGELOG updates.
CodeBlanch Jan 28, 2021
90daff7
Merging from main.
CodeBlanch Jan 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
CHANGELOG updates.
  • Loading branch information
@CodeBlanch
CodeBlanch committed Jan 28, 2021
commit 66e301a2e28beb795a2bc085604ac924c5a44c88
4 changes: 4 additions & 0 deletions src/OpenTelemetry.Exporter.Zipkin/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,10 @@
* Span tags will no longer be populated with Resource Attributes.
([#1663](https://github.com/open-telemetry/opentelemetry-dotnet/pull/1663))

* Spans will no longer be held in memory indefinitely when `ZipkinExporter`
cannot connect to the configured endpoint.
([#1726](https://github.com/open-telemetry/opentelemetry-dotnet/pull/1726))

## 1.0.0-rc1.1

Released 2020-Nov-17
Expand Down
3 changes: 3 additions & 0 deletions src/OpenTelemetry/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,9 @@
them to supported data types (long for int/short, double for float). For
invalid attributes we now throw an exception instead of logging an error.
([#1720](https://github.com/open-telemetry/opentelemetry-dotnet/pull/1720))
* `BatchExportProcessor` will now flush any remaining spans left in a `Batch`
after the export operation has completed.
([#1726](https://github.com/open-telemetry/opentelemetry-dotnet/pull/1726))

## 1.0.0-rc1.1

Expand Down