Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing ActivitySource from DiagnosticSource #1515

Merged
merged 9 commits into from
Nov 12, 2020
Merged

Fixing ActivitySource from DiagnosticSource #1515

merged 9 commits into from
Nov 12, 2020

Conversation

eddynaka
Copy link
Contributor

@eddynaka eddynaka commented Nov 12, 2020

Fixes #1522

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Design discussion issue #
  • Changes in public API reviewed

@eddynaka eddynaka self-assigned this Nov 12, 2020
@codecov
Copy link

codecov bot commented Nov 12, 2020

Codecov Report

Merging #1515 (2bfd714) into master (d1c174d) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1515      +/-   ##
==========================================
+ Coverage   81.34%   81.40%   +0.06%     
==========================================
  Files         233      233              
  Lines        6336     6358      +22     
==========================================
+ Hits         5154     5176      +22     
  Misses       1182     1182              
Impacted Files Coverage Δ
...trumentation.SqlClient/SqlClientInstrumentation.cs 100.00% <ø> (ø)
...umentation.AspNet/Implementation/HttpInListener.cs 89.10% <100.00%> (+0.44%) ⬆️
...tation.AspNetCore/Implementation/HttpInListener.cs 86.56% <100.00%> (+0.41%) ⬆️
...ent/Implementation/GrpcClientDiagnosticListener.cs 87.75% <100.00%> (+1.08%) ⬆️
...tp/Implementation/HttpHandlerDiagnosticListener.cs 77.50% <100.00%> (+1.18%) ⬆️
src/OpenTelemetry/Trace/ActivitySourceAdapter.cs 97.05% <100.00%> (+0.28%) ⬆️

@eddynaka
Copy link
Contributor Author

Running benchmark, I could not see any difference:
BEFORE

Method Mean Error StdDev Gen 0 Gen 1 Gen 2 Allocated
InstrumentedAspNetCoreGetPage 229.5 us 4.52 us 9.33 us 1.4648 - - 2.21 KB

AFTER

Method Mean Error StdDev Gen 0 Gen 1 Gen 2 Allocated
InstrumentedAspNetCoreGetPage 226.8 us 4.18 us 3.91 us 1.4648 - - 2.21 KB

@eddynaka eddynaka marked this pull request as ready for review November 12, 2020 01:33
@eddynaka eddynaka requested a review from a team November 12, 2020 01:33
@cijothomas
Copy link
Member

image
Confirmed that this fixed the OTLPExporter issue :)

Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cijothomas cijothomas merged commit eee0036 into open-telemetry:master Nov 12, 2020
@eddynaka eddynaka deleted the feature/fixing-instrumentation-diagnosticsource branch November 12, 2020 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DiagnosticSource instrumentations produce activities without ActivitySource.
2 participants