Enable enrich for HttpWebRequest #1407

eddynaka · 2020-10-27T19:41:58Z

Fixes #1401

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

CHANGELOG.md updated for non-trivial changes
Design discussion issue #
Changes in public API reviewed

codecov · 2020-10-27T19:50:28Z

Codecov Report

Merging #1407 into master will increase coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1407      +/-   ##
==========================================
+ Coverage   81.27%   81.32%   +0.04%     
==========================================
  Files         226      226              
  Lines        6088     6088              
==========================================
+ Hits         4948     4951       +3     
+ Misses       1140     1137       -3

Impacted Files	Coverage Δ
...ter.ZPages/Implementation/ZPagesActivityTracker.cs	`100.00% <0.00%> (+2.85%)`	⬆️
...ZPages/Implementation/ZPagesExporterEventSource.cs	`62.50% <0.00%> (+6.25%)`	⬆️
...us/Implementation/PrometheusExporterEventSource.cs	`72.72% <0.00%> (+9.09%)`	⬆️

src/OpenTelemetry.Instrumentation.Http/Implementation/HttpWebRequestActivitySource.netfx.cs

src/OpenTelemetry.Instrumentation.Http/CHANGELOG.md

cijothomas · 2020-10-27T20:05:20Z

src/OpenTelemetry.Instrumentation.Http/CHANGELOG.md

@@ -2,6 +2,11 @@

 ## Unreleased

+* Instrumentation no longer store raw objects like `HttpWebRequest` in


can you modify the README.md as well to reflect this change?

….com/eddynaka/opentelemetry-dotnet into feature/enable-enrich-httpwebrequest

Enable enrich for HttpWebRequest

a4f4fa2

eddynaka requested a review from a team October 27, 2020 19:41

updating changelog

5921fc7

eddynaka self-assigned this Oct 27, 2020