Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Resources in ZipkinExporter #1385

Merged
merged 6 commits into from
Oct 23, 2020

Conversation

CodeBlanch
Copy link
Member

@CodeBlanch CodeBlanch commented Oct 22, 2020

Changes

ZipkinExporter will now take service name from Resource if set and apply any Resource attributes as tags on outgoing spans. This brings it into parity with JaegerExporter w.r.t. Resources.

TODO

  • CHANGELOG.md updated for non-trivial changes
  • Changes in public API reviewed

@CodeBlanch CodeBlanch requested a review from a team October 22, 2020 19:55
@codecov
Copy link

codecov bot commented Oct 22, 2020

Codecov Report

Merging #1385 into master will increase coverage by 0.10%.
The diff coverage is 90.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1385      +/-   ##
==========================================
+ Coverage   81.18%   81.29%   +0.10%     
==========================================
  Files         226      226              
  Lines        6081     6094      +13     
==========================================
+ Hits         4937     4954      +17     
+ Misses       1144     1140       -4     
Impacted Files Coverage Δ
...plementation/ZipkinActivityConversionExtensions.cs 98.88% <ø> (+6.65%) ⬆️
...y.Exporter.Zipkin/Implementation/ZipkinEndpoint.cs 80.48% <71.42%> (-0.60%) ⬇️
...rc/OpenTelemetry.Exporter.Zipkin/ZipkinExporter.cs 85.71% <91.17%> (-0.19%) ⬇️
...rc/OpenTelemetry.Exporter.Jaeger/JaegerExporter.cs 84.94% <100.00%> (ø)
src/OpenTelemetry.Exporter.Jaeger/Process.cs 81.25% <100.00%> (ø)
...metry.Exporter.Zipkin/Implementation/ZipkinSpan.cs 95.50% <100.00%> (+0.10%) ⬆️
src/OpenTelemetry/Trace/ActivityExtensions.cs 100.00% <100.00%> (+20.00%) ⬆️
...emetry.Api/Internal/OpenTelemetryApiEventSource.cs 61.76% <0.00%> (-2.95%) ⬇️
...us/Implementation/PrometheusExporterEventSource.cs 72.72% <0.00%> (+9.09%) ⬆️

@CodeBlanch CodeBlanch merged commit 2d6792a into open-telemetry:master Oct 23, 2020
@CodeBlanch CodeBlanch deleted the zipkin-resource-support branch October 23, 2020 20:22
@CodeBlanch
Copy link
Member Author

Relates to #1294

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants