Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sampler implementations missing XML comments #575

Closed
MikeGoldsmith opened this issue Apr 7, 2020 · 0 comments
Closed

Sampler implementations missing XML comments #575

MikeGoldsmith opened this issue Apr 7, 2020 · 0 comments
Labels
pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package
Milestone
0.4.0-beta (Beta 1)

Comments

@MikeGoldsmith
Copy link
Member

All public class / structs should have XML comments to describe class, constructors, properties and methods.

  • Sampler
  • Samplers/ProbabilitySampler
  • Samplers/AlwaysOffSampler
  • Samplers/AlwaysOnSampler
  • Samplers/AlwaysParentSampler
@MikeGoldsmith MikeGoldsmith added the pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package label Apr 7, 2020
@MikeGoldsmith MikeGoldsmith added this to the Beta milestone Apr 7, 2020
@MikeGoldsmith MikeGoldsmith mentioned this issue Apr 7, 2020
Closed
37 tasks
@cijothomas cijothomas mentioned this issue Apr 21, 2020
Merged
Yun-Ting pushed a commit to Yun-Ting/opentelemetry-dotnet that referenced this issue Oct 13, 2022
@Kielek
[Instrumenation.GrpcCore] File scoped namespace (open-telemetry#575)
485409e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package
Projects
None yet
Milestone
0.4.0-beta (Beta 1)
Development

No branches or pull requests
2 participants
@MikeGoldsmith @cijothomas