[AWSLambda] Add faas.instance and faas.max_memory #2928
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martincostello
added
the
comp:instrumentation.awslambda
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2928 +/- ##
==========================================
+ Coverage 69.60% 69.67% +0.06%
==========================================
Files 413 413
Lines 16212 16225 +13
==========================================
+ Hits 11285 11305 +20
+ Misses 4927 4920 -7 Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
martincostello
had a problem deploying
to
external
GitHub Actions
Failure
martincostello
had a problem deploying
to
external
GitHub Actions
Failure
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for two additional OpenTelemetry semantic conventions attributes (faas.instance and faas.max_memory) to the AWS Lambda instrumentation library, enhancing observability capabilities.
- Implements retrieval of Lambda function instance ID from log stream name and memory limit from environment variables or context
- Adds the new attributes to both resource detection and span tagging
- Updates test infrastructure with default values and assertions for the new attributes
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
AWSLambdaUtils.cs |
Core implementation for extracting instance ID and memory size from Lambda context/environment |
AWSLambdaResourceDetector.cs |
Adds new attributes to resource detection |
AWSSemanticConventions.*.cs |
Defines the new semantic convention attribute constants and builder methods |
AWSLambdaWrapperTests.cs |
Updates test assertions and environment setup for new attributes |
SampleLambdaContext.cs |
Provides default test values for memory limit and log stream name |
CHANGELOG.md |
Documents the new feature addition |
opentelemetry-dotnet-contrib.sln |
Adds AWS shared files to solution structure |
src/OpenTelemetry.Instrumentation.AWSLambda/Implementation/AWSLambdaUtils.cs
Show resolved
Hide resolved
test/OpenTelemetry.Instrumentation.AWSLambda.Tests/AWSLambdaWrapperTests.cs
Show resolved
Hide resolved
martincostello
removed
the
comp:instrumentation.awslambda
martincostello
force-pushed
the
extend-aws-faas-attributes
branch
from
f071e77 to
d1e5871
Compare
martincostello
had a problem deploying
to
external
GitHub Actions
Failure
github-actions
bot
added
the
comp:instrumentation.awslambda
martincostello
force-pushed
the
extend-aws-faas-attributes
branch
from
d1e5871 to
2985977
Compare
martincostello
had a problem deploying
to
external
GitHub Actions
Failure
martincostello
force-pushed
the
extend-aws-faas-attributes
branch
from
2985977 to
16a0484
Compare
martincostello
had a problem deploying
to
external
GitHub Actions
Failure
martincostello
force-pushed
the
extend-aws-faas-attributes
branch
from
16a0484 to
d5ac8d9
Compare
martincostello
had a problem deploying
to
external
GitHub Actions
Failure
|
@philasmar, could you please check as you are seems the owner of https://github.com/aws/aws-lambda-dotnet? It seems that Philip is no longer affiliated to the AWS and it will be great to have someone with AWS expertise to cover ownership of this package. |
martincostello
force-pushed
the
extend-aws-faas-attributes
branch
from
d5ac8d9 to
bfdf2d9
Compare
martincostello
had a problem deploying
to
external
GitHub Actions
Failure
martincostello
force-pushed
the
extend-aws-faas-attributes
branch
from
bfdf2d9 to
8a5145a
Compare
martincostello
had a problem deploying
to
external
GitHub Actions
Failure
This was referenced Oct 23, 2025
Merged
Merged
Merged
Bump OpenTelemetry.Instrumentation.AspNetCore from 1.12.0 to 1.13.0
mishamyte/OpenTelemetry-Demo#430
Merged
Merged
Bump OpenTelemetry.Instrumentation.Http from 1.12.0 to 1.13.0
bervProject/NETCoreAPIBoilerplate#2968
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Set the
faas.instanceandfaas.max_memoryattributes for AWS Lambda functions, which are both recommended.Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changesChanges in public API reviewed (if applicable)