Replace ActivityExtensions.SetStatus by Activity.SetStatus

[Kielek]

Fixes #2321

Changes

Replace ActivityExtensions.SetStatus by Activity.SetStatus
Following tags will be not added to spans when the exception is recorder:
otel.status_code and otel.status_description. Both values are handled natively.

Changes affects only pre-released instrumentation packages. It should be safe to merge as is.

Merge requirement checklist

• CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
• Unit tests added/updated
• Appropriate CHANGELOG.md files updated for non-trivial changes
• [ ] Changes in public API reviewed (if applicable)

[codecov]

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 65.30%. Comparing base (71655ce) to head (085afcb).
Report is 624 commits behind head on main.

Files with missing lines	Patch %	Lines
...luentKafka/OpenTelemetryConsumeResultExtensions.cs	0.00%	1 Missing ⚠️
...mplementation/TelemetryDispatchMessageInspector.cs	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2358      +/-   ##
==========================================
- Coverage   73.91%   65.30%   -8.61%     
==========================================
  Files         267       98     -169     
  Lines        9615     2672    -6943     
==========================================
- Hits         7107     1745    -5362     
+ Misses       2508      927    -1581     

Flag	Coverage Δ
unittests-Instrumentation.AWS	86.27% <100.00%> (?)
unittests-Instrumentation.ConfluentKafka	14.37% <0.00%> (?)
unittests-Instrumentation.EntityFrameworkCore	57.06% <100.00%> (?)
unittests-Instrumentation.Owin	88.12% <100.00%> (?)
unittests-Instrumentation.Quartz	78.76% <100.00%> (?)
unittests-Instrumentation.Wcf	78.57% <50.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...ntation.AWS/Implementation/Tracing/AWSTraceSpan.cs	55.26% <100.00%> (ø)
...etry.Instrumentation.AWSLambda/AWSLambdaWrapper.cs	94.82% <100.00%> (ø)
...mplementation/EntityFrameworkDiagnosticListener.cs	53.03% <100.00%> (+0.64%)	⬆️
...ation.Owin/Implementation/DiagnosticsMiddleware.cs	94.79% <100.00%> (+2.93%)	⬆️
....Quartz/Implementation/QuartzDiagnosticListener.cs	82.60% <100.00%> (-4.49%)	⬇️
...Wcf/Implementation/ClientChannelInstrumentation.cs	93.50% <100.00%> (-1.30%)	⬇️
...luentKafka/OpenTelemetryConsumeResultExtensions.cs	0.00% <0.00%> (ø)
...mplementation/TelemetryDispatchMessageInspector.cs	88.88% <0.00%> (ø)

... and 290 files with indirect coverage changes

[g7ed6e]

LGTM

[CodeBlanch]

We may want to change this description. Suggestion something like:

• Trace instrumentation will now call the Activity.SetStatus API instead of the deprecated OpenTelemetry API package extension when setting span status. For details see: Setting Status.

Why?

The way it is currently written, a user might think otel.status_code and otel.status_description will no longer be present when the data hits the backend. But that depends largely on their exporter. For example Zipkin will add those based on the final Activity.Status/StatusDescription: https://github.com/open-telemetry/opentelemetry-dotnet/blob/0c775e58fa8eb55468f321d5612b527ed80afb9f/src/OpenTelemetry.Exporter.Zipkin/Implementation/ZipkinActivityConversionExtensions.cs#L51-L62

[CodeBlanch]

Suggest changing CHANGELOGs but fundamentally LGTM