Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[repo/Hangfire] Prepare to .NET9 #2296

Merged
merged 3 commits into from
Nov 5, 2024

Conversation

Kielek
Copy link
Contributor

@Kielek Kielek commented Nov 5, 2024

Changes

Follow up #2251

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • [ ] Unit tests added/updated
  • [ ] Appropriate CHANGELOG.md files updated for non-trivial changes
  • [ ] Changes in public API reviewed (if applicable)

@Kielek Kielek requested a review from a team as a code owner November 5, 2024 05:57
@github-actions github-actions bot requested a review from fred2u November 5, 2024 05:57
@github-actions github-actions bot added the comp:instrumentation.hangfire Things related to OpenTelemetry.Instrumentation.Hangfire label Nov 5, 2024
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.58%. Comparing base (71655ce) to head (b7eec6b).
Report is 583 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2296       +/-   ##
===========================================
+ Coverage   73.91%   93.58%   +19.67%     
===========================================
  Files         267        4      -263     
  Lines        9615       78     -9537     
===========================================
- Hits         7107       73     -7034     
+ Misses       2508        5     -2503     
Flag Coverage Δ
unittests-Instrumentation.Hangfire 93.58% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ation/HangfireInstrumentationJobFilterAttribute.cs 90.74% <100.00%> (+4.07%) ⬆️

... and 263 files with indirect coverage changes

@Kielek Kielek merged commit cca539c into open-telemetry:main Nov 5, 2024
55 checks passed
@Kielek Kielek deleted the net9prep-hangfire branch November 5, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:instrumentation.hangfire Things related to OpenTelemetry.Instrumentation.Hangfire
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants