Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[repo/StackDriver] Prepare to .NET9 #2270

Merged
merged 11 commits into from
Oct 29, 2024

Conversation

Kielek
Copy link
Contributor

@Kielek Kielek commented Oct 29, 2024

Changes

Follow up #2251

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • [ ] Unit tests added/updated
  • [ ] Appropriate CHANGELOG.md files updated for non-trivial changes
  • [ ] Changes in public API reviewed (if applicable)

@Kielek Kielek requested a review from a team as a code owner October 29, 2024 12:28
@github-actions github-actions bot added the comp:exporter.stackdriver Things related to OpenTelemetry.Exporter.Stackdriver label Oct 29, 2024
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 58.82353% with 7 lines in your changes missing coverage. Please review.

Project coverage is 79.26%. Comparing base (71655ce) to head (d8e9f1d).
Report is 559 commits behind head on main.

Files with missing lines Patch % Lines
...r.Stackdriver/Implementation/ActivityExtensions.cs 41.66% 7 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2270      +/-   ##
==========================================
+ Coverage   73.91%   79.26%   +5.35%     
==========================================
  Files         267        8     -259     
  Lines        9615      164    -9451     
==========================================
- Hits         7107      130    -6977     
+ Misses       2508       34    -2474     
Flag Coverage Δ
unittests-Exporter.Stackdriver 79.26% <58.82%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...y.Exporter.Stackdriver/StackdriverTraceExporter.cs 78.57% <100.00%> (+11.07%) ⬆️
...r.Stackdriver/Implementation/ActivityExtensions.cs 88.88% <41.66%> (+13.88%) ⬆️

... and 263 files with indirect coverage changes

Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kielek Kielek merged commit ae6d420 into open-telemetry:main Oct 29, 2024
55 checks passed
@Kielek Kielek deleted the net9prep-stackdriver branch October 29, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:exporter.stackdriver Things related to OpenTelemetry.Exporter.Stackdriver
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants