Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[repo/InfluxDB] Prepare to .NET9 #2268

Merged
merged 5 commits into from
Oct 29, 2024
Merged

Conversation

Kielek
Copy link
Contributor

@Kielek Kielek commented Oct 29, 2024

Changes

Follow up #2251

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • [ ] Unit tests added/updated
  • [ ] Appropriate CHANGELOG.md files updated for non-trivial changes
  • [ ] Changes in public API reviewed (if applicable)

@Kielek Kielek requested a review from a team as a code owner October 29, 2024 08:08
@github-actions github-actions bot requested a review from Havret October 29, 2024 08:08
@github-actions github-actions bot added the comp:exporter.influxdb Things related to OpenTelemetry.Exporter.InfluxDB label Oct 29, 2024
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.14%. Comparing base (71655ce) to head (11077d0).
Report is 556 commits behind head on main.

Files with missing lines Patch % Lines
...ry.Exporter.InfluxDB/InfluxDBExporterExtensions.cs 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2268       +/-   ##
===========================================
+ Coverage   73.91%   95.14%   +21.22%     
===========================================
  Files         267        7      -260     
  Lines        9615      247     -9368     
===========================================
- Hits         7107      235     -6872     
+ Misses       2508       12     -2496     
Flag Coverage Δ
unittests-Exporter.InfluxDB 95.14% <83.33%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...metry.Exporter.InfluxDB/InfluxDBMetricsExporter.cs 85.71% <100.00%> (-2.75%) ⬇️
...ry.Exporter.InfluxDB/TelegrafPrometheusWriterV1.cs 100.00% <100.00%> (ø)
...ry.Exporter.InfluxDB/TelegrafPrometheusWriterV2.cs 100.00% <100.00%> (ø)
...ry.Exporter.InfluxDB/InfluxDBExporterExtensions.cs 95.12% <50.00%> (-4.88%) ⬇️

... and 260 files with indirect coverage changes

Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kielek Kielek merged commit f6326f5 into open-telemetry:main Oct 29, 2024
55 checks passed
@Kielek Kielek deleted the net9prep-influxdb branch October 29, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:exporter.influxdb Things related to OpenTelemetry.Exporter.InfluxDB
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants