-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SemanticConvention] Migrate generation to Weaver and bump version to 1.26 #2040
[SemanticConvention] Migrate generation to Weaver and bump version to 1.26 #2040
Conversation
The error failures are because if missing xml docs for some old, deprecated otel attributes. I already fixed it in semconv.
For now, I will remove them from generation and can be added later once a new semconv version is released with my fix |
They don't have a brief which causes warnings with public API. Will re-add once a new semconv release is out.
src/OpenTelemetry.SemanticConventions/Attributes/K8sAttributes.cs
Outdated
Show resolved
Hide resolved
src/OpenTelemetry.SemanticConventions/scripts/templates/registry/common.j2
Outdated
Show resolved
Hide resolved
...Telemetry.SemanticConventions/scripts/templates/registry/SemanticConventionsAttributes.cs.j2
Outdated
Show resolved
Hide resolved
src/OpenTelemetry.SemanticConventions/scripts/templates/registry/weaver.yaml
Outdated
Show resolved
Hide resolved
...Telemetry.SemanticConventions/scripts/templates/registry/SemanticConventionsAttributes.cs.j2
Outdated
Show resolved
Hide resolved
src/OpenTelemetry.SemanticConventions/scripts/templates/registry/weaver.yaml
Show resolved
Hide resolved
Alright, thanks @cijothomas! I will look into it and send a separated PR. Edit: PR is there, let me know if that's something you had in mind |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2040 +/- ##
==========================================
- Coverage 73.91% 72.54% -1.38%
==========================================
Files 267 314 +47
Lines 9615 11829 +2214
==========================================
+ Hits 7107 8581 +1474
- Misses 2508 3248 +740 Flags with carried forward coverage won't be shown. Click here to find out more. |
...Telemetry.SemanticConventions/scripts/templates/registry/SemanticConventionsAttributes.cs.j2
Outdated
Show resolved
Hide resolved
src/OpenTelemetry.SemanticConventions/.publicApi/PublicAPI.Unshipped.txt
Outdated
Show resolved
Hide resolved
Will be done in a follow up open-telemetry#2068
Fixes #1944
Changes
v.1.26.0
as that's required for the Weaver moveMy goal with this initial PR is to do the minimum changes to get Weaver to work. To bring this package to stabilization, we will need more PRs to separate stable to unstable attributes.
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial changes