Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sql] Add option to sanitize db.query.text #2221

Open
alanwest opened this issue Oct 17, 2024 · 0 comments
Open

[sql] Add option to sanitize db.query.text #2221

alanwest opened this issue Oct 17, 2024 · 0 comments
Assignees
Labels
comp:instrumentation.sqlclient Things related to OpenTelemetry.Instrumentation.SqlClient enhancement New feature or request

Comments

@alanwest
Copy link
Member

alanwest commented Oct 17, 2024

Component

OpenTelemetry.Instrumentation.SqlClient

What is the expected behavior?

The collection of db.query.text is opt-in because it runs the risk of collecting sensitive information. Collecting db.query.text is often very valuable to end users. However, the only choices being a) not collecting it or b) risk exposing sensitive information is inadequate.

The instrumentation needs to offer a way to sanitize db.query.text allowing users to collect it without the risk of exposing sensitive information.

Sanitizing db.query.text is a costly operation. What this issue does not attempt to address is whether sanitization and collection of db.query.text should be on by default. For now, it should be implemented as opt-in, though later we should decide whether it should be on by default.

@alanwest alanwest added the enhancement New feature or request label Oct 17, 2024
@github-actions github-actions bot added the comp:instrumentation.sqlclient Things related to OpenTelemetry.Instrumentation.SqlClient label Oct 17, 2024
@alanwest alanwest changed the title [feature request] Add option to sanitize db.query.text [OpenTelemetry.Instrumentation.SqlClient] Add option to sanitize db.query.text Oct 17, 2024
@alanwest alanwest self-assigned this Oct 17, 2024
@alanwest alanwest changed the title [OpenTelemetry.Instrumentation.SqlClient] Add option to sanitize db.query.text [sql] Add option to sanitize db.query.text Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:instrumentation.sqlclient Things related to OpenTelemetry.Instrumentation.SqlClient enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant