instrumentation details for frontend #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cartersocha
reviewed
Jun 3, 2022
cartersocha
reviewed
Jun 3, 2022
cartersocha
reviewed
Jun 3, 2022
cijothomas
reviewed
Jun 3, 2022
cijothomas
reviewed
Jun 3, 2022
reyang
reviewed
Jun 3, 2022
reyang
reviewed
Jun 3, 2022
Co-authored-by: Reiley Yang <reyang@microsoft.com>
Co-authored-by: Reiley Yang <reyang@microsoft.com>
mic-max
reviewed
Jun 3, 2022
mic-max
reviewed
Jun 3, 2022
mic-max
reviewed
Jun 3, 2022
mic-max
reviewed
Jun 3, 2022
mic-max
reviewed
Jun 3, 2022
mic-max
reviewed
Jun 3, 2022
mic-max
approved these changes
Jun 3, 2022
fatsheep9146
reviewed
Jun 5, 2022
fatsheep9146
reviewed
Jun 5, 2022
austinlparker
approved these changes
Jun 8, 2022
|
Could we get the last few comments resolved here? |
6 tasks
GaryPWhite
pushed a commit
to wayfair-contribs/opentelemetry-demo
that referenced
this pull request
Jun 30, 2022
* instrumentation details for frontend * markdown lint * markdown lint * re-organized readme structure * Update src/frontend/README.md Co-authored-by: Reiley Yang <reyang@microsoft.com> * Update src/frontend/README.md Co-authored-by: Reiley Yang <reyang@microsoft.com> * small grammar, spelling fixes Co-authored-by: Carter Socha <43380952+cartersocha@users.noreply.github.com> Co-authored-by: Reiley Yang <reyang@microsoft.com>
jmichalak9
pushed a commit
to jmichalak9/opentelemetry-demo
that referenced
this pull request
Mar 22, 2024
* instrumentation details for frontend * markdown lint * markdown lint * re-organized readme structure * Update src/frontend/README.md Co-authored-by: Reiley Yang <reyang@microsoft.com> * Update src/frontend/README.md Co-authored-by: Reiley Yang <reyang@microsoft.com> * small grammar, spelling fixes Co-authored-by: Carter Socha <43380952+cartersocha@users.noreply.github.com> Co-authored-by: Reiley Yang <reyang@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adds a descriptive readme to frontend service with the following details:
For significant contributions please make sure you have completed the following items:
The structured flow details how to wire up Otel, how to add auto-instrumentation, how to add manual things in that order. Happy to change the order around, but when I think about easiest to hardest, that's how I see things.
I foresee when we add other instrumentation types (logs and metrics) we will likely need a table of contents to detail how different instrumentation types are accomplished.