Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cart] use 60m TTL for cart cache #779

Merged
merged 6 commits into from
Mar 15, 2023
Merged

[cart] use 60m TTL for cart cache #779

merged 6 commits into from
Mar 15, 2023

Conversation

puckpuck
Copy link
Contributor

@puckpuck puckpuck commented Mar 8, 2023

Uses a 60m TTL when items are set in the cart cache (redis). This was done to prevent the memory leak in redis. #771

  • CHANGELOG.md updated to document new feature additions

Setting this as a draft PR while doing a multi-day test to ensure memory usage stays level.

Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
@puckpuck puckpuck added the v1.4 required for 1.4 release label Mar 8, 2023
@puckpuck puckpuck marked this pull request as ready for review March 10, 2023 00:49
@puckpuck puckpuck requested a review from a team March 10, 2023 00:49
@puckpuck
Copy link
Contributor Author

This one is ready for review, but waiting on #788 to get merged so I can update the changelog

Copy link
Member

@julianocosta89 julianocosta89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cartersocha cartersocha merged commit ee71c0c into open-telemetry:main Mar 15, 2023
mat-rumian pushed a commit to SumoLogic/opentelemetry-demo that referenced this pull request Mar 20, 2023
@puckpuck puckpuck deleted the cart.use_ttl_for_cache branch March 23, 2023 15:03
juliangiuca pushed a commit to juliangiuca/opentelemetry-demo that referenced this pull request Apr 12, 2023
jmichalak9 pushed a commit to jmichalak9/opentelemetry-demo that referenced this pull request Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v1.4 required for 1.4 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants