-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔭 [Frontend/ProductCatalogService] Updated Product Catalog Service Data to Match Astronomy Store #285
🔭 [Frontend/ProductCatalogService] Updated Product Catalog Service Data to Match Astronomy Store #285
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of the images could have legal/copyright concerns, e.g. https://raw.githubusercontent.com/open-telemetry/opentelemetry-demo/e55ee5f4e734e38e5ad1a7dd6713509d70da63b9/src/frontend/public/products/LensCleaningKit.webp seems to be coming from https://www.amazon.com/Celestron-93576-Lens-Cleaning-Kit/dp/B08N5D9LXH.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @mic-max & @reyang thanks for your review. I'm getting the non-copyrighted images and I'll be updating the PR. For the /tests/ I found out all of the tests are failing because of this change 55d9919 I think we should run the tests within the containers context so we don't have to expose the ports to localhost. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Could we get a changelog entry and potentially readme guidance on how to add more items? The readme update can potentially follow in another pr |
We should agree on some sort of file naming conventions to follow too. Our docs are word_word and pictures are word-word. These new images are WordWord. |
I'm fine with pictures all one way and markdown files the other but we need some sort of consistency here |
Did we address @reyang's concern about ensuring all images are not copyrighted? If so, we can resolve that conversation and merge this. |
I just added a changelog entry and I think it should be ready to be merged. @cartersocha I'll add the steps to add a new product on a separate PR if you don't mind. CC: @puckpuck |
@cartersocha the copyright issue has been solved as well |
@xoscar update & we can merge! |
@cartersocha done 😄 |
…ta to Match Astronomy Store (open-telemetry#285)
Fixes #282.
Changes
Updates the product service catalog data to have products that match the OTEL astronomy theme.
https://www.loom.com/share/828a3e2e6b1e4802894abeb3deda9464