Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[otel-col] Add host metrics receiver #1675

Merged

Conversation

rogercoll
Copy link
Contributor

@rogercoll rogercoll commented Jul 17, 2024

Changes

This PR adds the hostmetrics receiver to the demo.

Related issue: #1653

Merge Requirements

For new features contributions please make sure you have completed the following
essential items:

  • CHANGELOG.md updated to document new feature additions
    * [ ] Appropriate documentation updates in the docs
    * [ ] Appropriate Helm chart updates in the helm-charts

Maintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.

@github-actions github-actions bot added the helm-update-required Requires an update to the Helm chart when released label Jul 17, 2024
@rogercoll rogercoll changed the title feat: add hostmetrics receiver for docker deployment [otel-col] Add host metrics receiver Jul 17, 2024
@rogercoll
Copy link
Contributor Author

Draft PR to enable them in Helm: open-telemetry/opentelemetry-helm-charts#1261

src/otelcollector/otelcol-config.yml Show resolved Hide resolved
src/otelcollector/otelcol-config.yml Show resolved Hide resolved
src/otelcollector/otelcol-config.yml Show resolved Hide resolved
src/otelcollector/otelcol-config.yml Show resolved Hide resolved
src/otelcollector/otelcol-config.yml Show resolved Hide resolved
src/otelcollector/otelcol-config.yml Show resolved Hide resolved
@julianocosta89
Copy link
Member

@rogercoll LGTM, I've added some suggestions, but definitely not a blocker

rogercoll and others added 2 commits July 19, 2024 09:19
@julianocosta89 julianocosta89 merged commit 1dc31d0 into open-telemetry:main Jul 23, 2024
28 checks passed
@rogercoll rogercoll deleted the add_hostmetrics_receiver branch July 23, 2024 09:16
ahealy-newr pushed a commit to ahealy-newr/opentelemetry-demo-ahealy that referenced this pull request Jul 24, 2024
* feat: add hostmetrics receiver for docker deployment

* chore: add changelog entry

* Update src/otelcollector/otelcol-config.yml

Co-authored-by: Juliano Costa <julianocosta89@outlook.com>

* enable hostmetrics memory utilization metric

---------

Co-authored-by: Juliano Costa <julianocosta89@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
helm-update-required Requires an update to the Helm chart when released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants