Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[checkout] - add manual tracing instrumentation #164

Merged
merged 10 commits into from
Jul 19, 2022
Merged

[checkout] - add manual tracing instrumentation #164

merged 10 commits into from
Jul 19, 2022

Conversation

puckpuck
Copy link
Contributor

Fixes #56

  • Services extend automatic instrumentation.
    • New attributes/events attached to existing spans.
    • New spans are being created from existing spans.

Changes

  • add attributes and events with more attributes to the existing auto-instrumented span.
  • wraps the main prepareOrderItems function with another span and attributes.
  • fixes a small bug that prevented passing context into the currency service calls.

@puckpuck puckpuck requested a review from a team June 23, 2022 03:20
mic-max
mic-max suggested changes Jun 28, 2022
View reviewed changes
Copy link
Contributor

@mic-max mic-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the nano conversion changes applied!

src/checkoutservice/main.go Outdated Show resolved Hide resolved
src/checkoutservice/main.go Outdated Show resolved Hide resolved
src/checkoutservice/main.go Outdated Show resolved Hide resolved
src/checkoutservice/main.go Outdated Show resolved Hide resolved
puckpuck and others added 6 commits June 29, 2022 19:35
@puckpuck @mic-max
Update src/checkoutservice/main.go
61ebdf6 
Co-authored-by: Michael Maxwell <mike.ian.maxwell@gmail.com>
@puckpuck @mic-max
Update src/checkoutservice/main.go
012ee19 
Co-authored-by: Michael Maxwell <mike.ian.maxwell@gmail.com>
@puckpuck @mic-max
Update src/checkoutservice/main.go
b92faa5 
Co-authored-by: Michael Maxwell <mike.ian.maxwell@gmail.com>
@puckpuck
add error event to span
c8606e9
@puckpuck
reuse common attribute
78239fd
@puckpuck
Merge branch 'main' into puckpuck.checkout-manual-instrumentation
daab66a
@puckpuck
Copy link
Contributor Author

I'm not sure why it's still asking for changes to be reviewed. They should all be resolved now.

@cartersocha cartersocha requested a review from mic-max June 30, 2022 20:57
@cartersocha
Copy link
Contributor

@mic-max can you reset your review?

julianocosta89
julianocosta89 approved these changes Jul 2, 2022
View reviewed changes
Copy link
Member

@julianocosta89 julianocosta89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments but not blockers, we can standardize the span attribute names later.

src/checkoutservice/main.go Outdated Show resolved Hide resolved
@github-actions
Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jul 13, 2022
@austinlparker
Copy link
Member

Bumping this -- are we ok with this for now or are we gonna let it rot?

@cartersocha
Copy link
Contributor

Bumping this -- are we ok with this for now or are we gonna let it rot?

Pierre just got back from vacation & is going to update it today or tomorrow. I briefly mentioned it in the sig meeting today

@github-actions github-actions bot removed the Stale label Jul 19, 2022
@cartersocha cartersocha merged commit a05a228 into open-telemetry:main Jul 19, 2022
@puckpuck puckpuck deleted the puckpuck.checkout-manual-instrumentation branch August 3, 2022 22:55
jmichalak9 pushed a commit to jmichalak9/opentelemetry-demo that referenced this pull request Mar 22, 2024
@puckpuck @mic-max
[checkout] - add manual tracing instrumentation (open-telemetry#164)
edec6f0 
* add manual spans and attributes

* Update src/checkoutservice/main.go

Co-authored-by: Michael Maxwell <mike.ian.maxwell@gmail.com>

* Update src/checkoutservice/main.go

Co-authored-by: Michael Maxwell <mike.ian.maxwell@gmail.com>

* Update src/checkoutservice/main.go

Co-authored-by: Michael Maxwell <mike.ian.maxwell@gmail.com>

* add error event to span

* reuse common attribute

* reuse common attribute name

Co-authored-by: Michael Maxwell <mike.ian.maxwell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cartersocha cartersocha cartersocha left review comments

@fatsheep9146 fatsheep9146 fatsheep9146 left review comments

@julianocosta89 julianocosta89 julianocosta89 approved these changes

@mic-max mic-max mic-max approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Review and enhance tracing support for checkout service (Go)
6 participants
@puckpuck @cartersocha @austinlparker @fatsheep9146 @mic-max @julianocosta89