Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[checkoutservice] adds otel logging support #1478

Conversation

Kimbohlovette
Copy link

This PR implements otel log support in the checkout service

@Kimbohlovette Kimbohlovette requested a review from a team March 23, 2024 18:28
@Kimbohlovette
Copy link
Author

@puckpuck please could you take a look at this PR?
@jpkrohling

@Kimbohlovette Kimbohlovette force-pushed the Add-otel-log-support-to-checkout-service branch from 1d153c6 to cbd0c9c Compare March 24, 2024 01:01
@Kimbohlovette Kimbohlovette changed the title Adds otel log support to checkout service [checkoutservice] adds otel logging support Mar 24, 2024
Copy link
Member

@austinlparker austinlparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See review comment on #1477

Copy link

github-actions bot commented Apr 2, 2024

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Apr 2, 2024
@github-actions github-actions bot removed the Stale label Apr 3, 2024
@julianocosta89 julianocosta89 marked this pull request as draft April 3, 2024 11:09
@julianocosta89
Copy link
Member

I spoke with @Kimbohlovette today and mentioned that this is not supported yet as OTel logs in Go are still in development.
He will reach out to the OTel Go team to check if he can help out on bringing this to Stable.

Closing this PR for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants