Remove scheme from OTLP endpoint before passing to gRPC #988
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #986
Changes
According to https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/protocol/exporter.md, URI scheme like
http
orhttps
are allowed in the OTLP endpoint, but causes problem in naming resolving in gRPC. This change removes the URI scheme for OTLP gRPC.For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes