Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Idar oss/build error memcpy #987

Merged
merged 3 commits into from
Sep 21, 2021

Conversation

idarb-oss
Copy link
Contributor

Fixes #985

Changes

Add include statement of cstring to opentelemetry-cpp/api/include/opentelemetry/common/kv_properties.h which caused build error for missing memcpy in scope.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@idarb-oss idarb-oss requested a review from a team September 21, 2021 09:05
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 21, 2021

CLA Signed

The committers are authorized under a signed CLA.

@ThomsonTan
Copy link
Contributor

@idarb-oss thanks for your contribution. Please fix the CLA issue and resolve the conflict in the CHANGELOG file.

@idarb-oss
Copy link
Contributor Author

@ThomsonTan CLA issue fixed and merge conflict resolved

@codecov
Copy link

codecov bot commented Sep 21, 2021

Codecov Report

Merging #987 (459fa97) into main (5de793d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #987   +/-   ##
=======================================
  Coverage   95.41%   95.41%           
=======================================
  Files         161      161           
  Lines        6833     6833           
=======================================
  Hits         6519     6519           
  Misses        314      314           
Impacted Files Coverage Δ
api/include/opentelemetry/common/kv_properties.h 98.89% <ø> (ø)

@lalitb lalitb merged commit 530cb30 into open-telemetry:main Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build error where memcpy is not declared in scope
3 participants