Add resource and instrumentation library support for OStreamSpanExporter #906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #906 +/- ##
==========================================
+ Coverage 95.40% 95.44% +0.04%
==========================================
Files 158 158
Lines 6717 6749 +32
==========================================
+ Hits 6408 6441 +33
+ Misses 309 308 -1
|
ThomsonTan
approved these changes
Jul 16, 2021
| { | ||
| if (resource_ == nullptr) | ||
| { | ||
| // this shouldn't happen as TraceProvider provides default resources |
There was a problem hiding this comment.
Yes, that's one of the options. I just felt it's better to avoid asserting application if we can handle it gracefully. That also let us create unit-tests for ostream exporter ( which uses span-data) without depending on TracerProvider to pass the resources.
| { | ||
| if (instrumentation_library_ == nullptr) | ||
| { | ||
| // this shouldn't happen as Tracer ensures there is valid default instrumentation library. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
OStreamSpanExporter span exporter doesn't export resources and instrumentation library. This makes it difficult to debug issues related to resources/instrumentation library. This PR adds support for it.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes