Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Zipkin AddEvent() timestamp #896

Merged
merged 3 commits into from
Jul 9, 2021
Merged

Conversation

lalitb
Copy link
Member

@lalitb lalitb commented Jul 8, 2021

Changes

A small change to record the Zipkin event timestamp in microseconds, as in the specs:
https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/sdk_exporters/zipkin.md#unit-of-time
Zipkin times like timestamp, duration and annotation.timestamp MUST be reported in microseconds as whole numbers. For example, duration of 1234 nanoseconds will be represented as 1 microsecond.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@lalitb lalitb requested a review from a team July 8, 2021 12:59
@codecov
Copy link

codecov bot commented Jul 8, 2021

Codecov Report

Merging #896 (9686df5) into main (124087f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #896   +/-   ##
=======================================
  Coverage   95.40%   95.40%           
=======================================
  Files         158      158           
  Lines        6717     6717           
=======================================
  Hits         6408     6408           
  Misses        309      309           

@lalitb lalitb merged commit 20b315a into open-telemetry:main Jul 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants