-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update opentelemetry-proto
submodule to version from May 18, 2021
#825
Conversation
Codecov Report
@@ Coverage Diff @@
## main #825 +/- ##
=======================================
Coverage 95.52% 95.52%
=======================================
Files 156 156
Lines 6618 6618
=======================================
Hits 6321 6321
Misses 297 297 |
Is it more conservative to snap the latest tag instead of main branch? |
My understanding is it's generally both cd submodule
git pull
cd ..
git add submodule
git commit -m "Updated version to X" This guarantees that by default when you perform recursive cloning, you get a set of deps, a baseline that is guaranteed to work / passes CI. It would've been a bit less predictable if we automated that process to automagically update whenever there's a new commit in the proto repo ( we could, but I don't think we should ). |
Thanks for the update. Should we also update the proto package used by bazel as part of this PR: opentelemetry-cpp/bazel/repository.bzl Line 48 in 93dd39b
|
Merging now. For bazel, we can do it in separate PR. |
Update
opentelemetry-proto
submodule from 5 months old to latest version:No other code changes.