Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to build WITH_JAEGER in Visual Studio 2019 + CMake #815

Merged
merged 4 commits into from
Jun 2, 2021
Merged

Allow to build WITH_JAEGER in Visual Studio 2019 + CMake #815

merged 4 commits into from
Jun 2, 2021

Commits on Jun 2, 2021

  1. Update CMakeLists.txt 

    Can't build WITh_JAEGER on Windows because Thrift was not installed in Visual Studio 2019 and `tools/build.cmd` build
    @maxgolov
    maxgolov authored Jun 2, 2021
    Configuration menu
    Copy the full SHA
    9004507 View commit details
    Browse the repository at this point in the history

  2. Update CMakeLists.txt 

    vcpkg installed Thrift points to .\thrift whereas thrift-gen expects path 1-level up
    @maxgolov
    maxgolov authored Jun 2, 2021
    Configuration menu
    Copy the full SHA
    77c991c View commit details
    Browse the repository at this point in the history

  3. Update setup-buildtools.cmd 

    Install Thrift as it is required for Jaeger exporter
    @maxgolov
    maxgolov authored Jun 2, 2021
    Configuration menu
    Copy the full SHA
    1246d67 View commit details
    Browse the repository at this point in the history

  4. Update CMakeLists.txt 

    Add period
    @maxgolov
    maxgolov authored Jun 2, 2021
    Configuration menu
    Copy the full SHA
    fd759f0 View commit details
    Browse the repository at this point in the history