Non-template propagator, Implement Global Propagator, no-op propagator#668
Merged
lalitb merged 12 commits intoopen-telemetry:mainfrom Apr 23, 2021
Merged
Non-template propagator, Implement Global Propagator, no-op propagator#668lalitb merged 12 commits intoopen-telemetry:mainfrom
lalitb merged 12 commits intoopen-telemetry:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #668 +/- ##
==========================================
+ Coverage 94.75% 94.78% +0.03%
==========================================
Files 210 212 +2
Lines 9647 9707 +60
==========================================
+ Hits 9141 9201 +60
Misses 506 506
|
ThomsonTan
reviewed
Apr 22, 2021
api/include/opentelemetry/trace/propagation/text_map_propagator.h
Outdated
Show resolved
Hide resolved
api/include/opentelemetry/trace/propagation/text_map_propagator.h
Outdated
Show resolved
Hide resolved
ThomsonTan
approved these changes
Apr 22, 2021
jsuereth
approved these changes
Apr 22, 2021
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #540
Changes
Please provide a brief description of the changes here.
In continuation with discussion in Add Global Propagator, Noop Propagator #644, remove the templatized propagator class, so that the propagator is not compiled against its carrier/target type, and the carrier/target type is instead passed as
TextMapCarrierobject in Inject() and Extract() functions. This further allows not to create global/composite propagator per carrier/target type. As an example, a global propagator once set, can be used to extract the context from (say) gRPC response, and pass the context to (say) HTTP request.Provide an implementation of global and No-op propagator.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes