Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Recordable implementation for otprotocol exporter #49

Merged
merged 49 commits into from
Apr 6, 2020
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
49 commits
Select commit Hold shift + click to select a range
3503d72
Start Recorder api
rnburn Mar 3, 2020
79b4f1d
Fill out Span api
rnburn Mar 3, 2020
8bcff6e
Reformat
rnburn Mar 3, 2020
c5e9a9e
Fill out Tracer class
rnburn Mar 3, 2020
a69206f
Add cmake build
rnburn Mar 4, 2020
87170e3
Add commenting
rnburn Mar 4, 2020
4c7d2c0
Merge branch 'master' of https://github.com/open-telemetry/openteleme…
rnburn Mar 4, 2020
320add0
Fix formatting
rnburn Mar 4, 2020
1a3761e
Reformat
rnburn Mar 4, 2020
597f0f3
Fix date
rnburn Mar 4, 2020
0d8649f
Make mutex mutable
rnburn Mar 4, 2020
c15286e
s/mutex_/mu_/
rnburn Mar 4, 2020
3c6fbb0
Remove AddEvent with steady timestamp
rnburn Mar 5, 2020
b0d1548
Fix typo
rnburn Mar 6, 2020
6210da0
Fill in IsRecordable
rnburn Mar 6, 2020
c619e2b
Set up protobuf dependency
rnburn Mar 10, 2020
84d5ccd
Install protobuf in docker image
rnburn Mar 10, 2020
23c23b6
Merge branch 'recorder-interface' into otprotocol
rnburn Mar 10, 2020
eecc683
Merge in Recordable
rnburn Mar 10, 2020
414957f
Add exporter folder
rnburn Mar 10, 2020
c8fc557
Integrate protobuf files into build
rnburn Mar 11, 2020
b98eb9d
Add otprotocol Recordable
rnburn Mar 11, 2020
d2e2198
Set up protobuf with bazel
rnburn Mar 12, 2020
f470dd0
Reformat
rnburn Mar 12, 2020
51f9182
Install git in CI
rnburn Mar 12, 2020
d240118
Add otprotocol to cmake test
rnburn Mar 12, 2020
427314a
Fix typo
rnburn Mar 12, 2020
5f5050c
Fix install_protobuf.sh
rnburn Mar 12, 2020
092bd8d
Fix install_protobuf.sh
rnburn Mar 12, 2020
a979b8e
Fix install_protobuf.sh
rnburn Mar 12, 2020
fda73fe
Fix do_ci.sh
rnburn Mar 12, 2020
366e9e0
Add otprotocol windows tests
rnburn Mar 12, 2020
9094a52
Fix typo
rnburn Mar 12, 2020
b3d611b
Make protobuf install optional for windows
rnburn Mar 12, 2020
3b94521
Fix install_windows_protobuf.ps1
rnburn Mar 12, 2020
04284e0
Merge branch 'master' of https://github.com/open-telemetry/openteleme…
rnburn Mar 13, 2020
27e8526
Remove unnecessary globs
rnburn Mar 13, 2020
1fbb06e
Refactor
rnburn Mar 17, 2020
2f3296c
Rearrange protobuf files
rnburn Mar 19, 2020
49c27fe
Clean up workspace
rnburn Mar 19, 2020
28c8e5b
Fix formatting
rnburn Mar 19, 2020
f16dd46
Merge branch 'master' of https://github.com/open-telemetry/openteleme…
rnburn Mar 26, 2020
6f5316c
Update CI
rnburn Mar 26, 2020
2db1682
Merge branch 'master' of https://github.com/open-telemetry/openteleme…
rnburn Apr 4, 2020
1d83819
Restructure
rnburn Apr 4, 2020
f64c826
Reformat
rnburn Apr 4, 2020
49c375f
Refactor legacy test
rnburn Apr 6, 2020
ab62b01
Fix legacy target
rnburn Apr 6, 2020
336d466
Fix legacy target
rnburn Apr 6, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ jobs:
- run: ./ci/setup_ci_environment.sh
- run: ./ci/install_bazelisk.sh
- run: ./ci/install_gcc48.sh
- run: CC=/usr/bin/g++-4.8 ./ci/do_ci.sh bazel.test
- run: CC=/usr/bin/g++-4.8 ./ci/do_ci.sh bazel.test_api
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API is gcc 4.8 compatible but SDK is not?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

protobuf can't work with gcc-4.8.

Maybe I should exclude just some portions of the sdk from legacy compiler tests?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Up to you. Sorry to hear about protobuf.


bazel_test:
resource_class: xlarge
Expand Down
2 changes: 2 additions & 0 deletions ci/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ CI tests can be run on docker by invoking the script `./ci/run_docker.sh ./ci/do

* `cmake.test`: build cmake targets and run tests.
* `cmake.test_example_plugin`: build and test an example OpenTelemetry plugin.
* `cmake.exporter.otprotocol.test`: build and test the otprotocol exporter
* `bazel.test_api`: build bazel targets and run tests for the api only.
* `bazel.test`: build bazel targets and run tests.
* `bazel.noexcept`: build bazel targets and run tests with exceptions disabled.
* `bazel.asan`: build bazel targets and run tests with AddressSanitizer.
Expand Down
4 changes: 4 additions & 0 deletions ci/do_ci.sh
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,10 @@ EOF
make load_plugin_example
examples/plugin/load/load_plugin_example ${PLUGIN_DIR}/libexample_plugin.so /dev/null
exit 0
elif [[ "$1" == "bazel.test_api" ]]; then
bazel build $BAZEL_OPTIONS //api/...
bazel test $BAZEL_TEST_OPTIONS //api/...
exit 0
elif [[ "$1" == "bazel.test" ]]; then
bazel build $BAZEL_OPTIONS //...
bazel test $BAZEL_TEST_OPTIONS //...
Expand Down