Add Ostream log exporter and tests #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #430 +/- ##
==========================================
+ Coverage 94.21% 94.37% +0.15%
==========================================
Files 182 185 +3
Lines 7853 8014 +161
==========================================
+ Hits 7399 7563 +164
+ Misses 454 451 -3
|
g-easy
reviewed
Dec 9, 2020
exporters/ostream/include/opentelemetry/exporters/ostream/log_exporter.h
Outdated
Show resolved
Hide resolved
lalitb
reviewed
Dec 9, 2020
exporters/ostream/include/opentelemetry/exporters/ostream/log_exporter.h
Outdated
Show resolved
Hide resolved
exporters/ostream/include/opentelemetry/exporters/ostream/log_exporter.h
Outdated
Show resolved
Hide resolved
ThomsonTan
reviewed
Dec 9, 2020
This was referenced Dec 9, 2020
MarkSeufert
reviewed
Dec 11, 2020
MarkSeufert
reviewed
Dec 12, 2020
kxyr
force-pushed
the
logs-ostream-exporter
branch
4 times, most recently
from
05ef3d5
to
e663e80
Compare
kxyr
force-pushed
the
logs-ostream-exporter
branch
from
e663e80
to
329f144
Compare
|
@lalitb @g-easy @ThomsonTan Would love another review on this! (Just updated with the newly merged Recordable interface from #438) |
kxyr
commented
Dec 15, 2020
kxyr
force-pushed
the
logs-ostream-exporter
branch
2 times, most recently
from
dc26c11
to
5ee27ca
Compare
kxyr
force-pushed
the
logs-ostream-exporter
branch
from
5ee27ca
to
8f9dc4d
Compare
ThomsonTan
reviewed
Dec 15, 2020
exporters/ostream/include/opentelemetry/exporters/ostream/log_exporter.h
Outdated
Show resolved
Hide resolved
ThomsonTan
reviewed
Dec 15, 2020
ThomsonTan
reviewed
Dec 15, 2020
ThomsonTan
reviewed
Dec 15, 2020
ThomsonTan
approved these changes
Dec 15, 2020
jsuereth
requested changes
Dec 15, 2020
exporters/ostream/include/opentelemetry/exporters/ostream/log_exporter.h
Outdated
Show resolved
Hide resolved
kxyr
force-pushed
the
logs-ostream-exporter
branch
from
4dfdfa6
to
6c94e6e
Compare
jsuereth
approved these changes
Dec 18, 2020
kxyr
pushed a commit
to open-o11y/opentelemetry-cpp
that referenced
this pull request
Dec 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds:
cc @MarkSeufert @alolita