Configure ryml to use exceptions when using CMAKE#3852
Open
BugelNiels wants to merge 1 commit intoopen-telemetry:mainfrom
Open
Configure ryml to use exceptions when using CMAKE#3852BugelNiels wants to merge 1 commit intoopen-telemetry:mainfrom
BugelNiels wants to merge 1 commit intoopen-telemetry:mainfrom
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3852 +/- ##
=======================================
Coverage 89.99% 89.99%
=======================================
Files 225 225
Lines 7168 7168
=======================================
Hits 6450 6450
Misses 718 718 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3851
Changes
When building
opentelemetry-cppand ryml is fetched from the repo using CMake, ryml will useabort()when it encounters errors. This results in unintended crashes and prevents the calling application from gracefully dealing with these errors. This PR ensures that when we fetch ryml, we configure it to use exceptions instead.For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes