Skip to content

Configure ryml to use exceptions when using CMAKE#3852

Open
BugelNiels wants to merge 1 commit intoopen-telemetry:mainfrom
BugelNiels:replace-ryml-abort-with-exceptions
Open

Configure ryml to use exceptions when using CMAKE#3852
BugelNiels wants to merge 1 commit intoopen-telemetry:mainfrom
BugelNiels:replace-ryml-abort-with-exceptions

Conversation

@BugelNiels
Copy link

Fixes #3851

Changes

When building opentelemetry-cpp and ryml is fetched from the repo using CMake, ryml will use abort() when it encounters errors. This results in unintended crashes and prevents the calling application from gracefully dealing with these errors. This PR ensures that when we fetch ryml, we configure it to use exceptions instead.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@BugelNiels BugelNiels requested a review from a team as a code owner February 7, 2026 17:37
@linux-foundation-easycla
Copy link

CLA Not Signed

@codecov
Copy link

codecov bot commented Feb 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.99%. Comparing base (bb5fff0) to head (a7d0e4f).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3852   +/-   ##
=======================================
  Coverage   89.99%   89.99%           
=======================================
  Files         225      225           
  Lines        7168     7168           
=======================================
  Hits         6450     6450           
  Misses        718      718           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@marcalff marcalff added the pr:waiting-on-cla Waiting on CLA label Feb 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:waiting-on-cla Waiting on CLA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rapidyaml calls abort() on parse failures of declarative config

2 participants