[BUILD] Ignore deprecated warning by owent · Pull Request #3845 · open-telemetry/opentelemetry-cpp

owent · 2026-02-05T06:37:52Z

Changes

Fixes deprecated warning scope

For significant contributions please make sure you have completed the following items:

CHANGELOG.md updated for non-trivial changes
Unit tests have been added
Changes in public API reviewed

Copilot

Pull request overview

This pull request aims to fix deprecated warning (C4996) in MSVC when including opentelemetry/logs/provider.h. The issue reported that users including this header for legitimate APIs (GetLoggerProvider/SetLoggerProvider) were encountering build failures due to deprecation warnings from internal implementation details involving the deprecated EventLogger APIs.

Changes:

Adjusted pragma warning scopes to suppress deprecation warnings around internal uses of deprecated EventLogger/EventLoggerProvider types in both the Provider class and noop implementations
Added explicit destructors to NoopEventLogger and NoopEventLoggerProvider classes

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.

File	Description
api/include/opentelemetry/logs/provider.h	Moved pragma warning suppressions to wrap public deprecated methods and private GetEventProvider() method that instantiates deprecated types
api/include/opentelemetry/logs/noop.h	Expanded pragma warning scope to cover entire NoopEventLogger and NoopEventLoggerProvider class definitions, added explicit destructors

Copilot · 2026-02-05T06:41:14Z

api/include/opentelemetry/logs/provider.h

 #  elif defined(__GNUC__) && !defined(__clang__) && !defined(__apple_build_version__)
 #    pragma GCC diagnostic push
-#    pragma GCC diagnostic ignored "-Wdeprecated-declarations"
+#    pragma GCC diagnostic warning "-Wdeprecated-declarations"


The pragma directive #pragma GCC diagnostic warning "-Wdeprecated-declarations" will cause deprecation warnings to be emitted as warnings for GCC, which contradicts the intent of suppressing these internal implementation warnings. This should be #pragma GCC diagnostic ignored "-Wdeprecated-declarations" to suppress the warnings like it was before, matching the behavior for MSVC which uses disable : 4996.

Copilot · 2026-02-05T06:41:14Z

api/include/opentelemetry/logs/provider.h

 #  elif defined(__clang__) || defined(__apple_build_version__)
 #    pragma clang diagnostic push
-#    pragma clang diagnostic ignored "-Wdeprecated-declarations"
+#    pragma clang diagnostic warning "-Wdeprecated-declarations"


The pragma directive #pragma clang diagnostic warning "-Wdeprecated-declarations" will cause deprecation warnings to be emitted as warnings for Clang, which contradicts the intent of suppressing these internal implementation warnings. This should be #pragma clang diagnostic ignored "-Wdeprecated-declarations" to suppress the warnings like it was before, matching the behavior for MSVC which uses disable : 4996.

Copilot · 2026-02-05T06:41:14Z

api/include/opentelemetry/logs/noop.h

+#    pragma GCC diagnostic warning "-Wdeprecated-declarations"
+#  elif defined(__clang__) || defined(__apple_build_version__)
+#    pragma clang diagnostic push
+#    pragma clang diagnostic warning "-Wdeprecated-declarations"


The pragma directive #pragma GCC diagnostic warning "-Wdeprecated-declarations" will cause deprecation warnings to be emitted as warnings for GCC, which contradicts the intent of suppressing these internal implementation warnings. This should be #pragma GCC diagnostic ignored "-Wdeprecated-declarations" to suppress the warnings like it was before, matching the behavior for MSVC which uses disable : 4996.

Suggested change

# pragma GCC diagnostic warning "-Wdeprecated-declarations"

# elif defined(__clang__) || defined(__apple_build_version__)

# pragma clang diagnostic push

# pragma clang diagnostic warning "-Wdeprecated-declarations"

# pragma GCC diagnostic ignored "-Wdeprecated-declarations"

# elif defined(__clang__) || defined(__apple_build_version__)

# pragma clang diagnostic push

# pragma clang diagnostic ignored "-Wdeprecated-declarations"

Copilot · 2026-02-05T06:41:15Z

api/include/opentelemetry/logs/noop.h

+#    pragma GCC diagnostic warning "-Wdeprecated-declarations"
+#  elif defined(__clang__) || defined(__apple_build_version__)
+#    pragma clang diagnostic push
+#    pragma clang diagnostic warning "-Wdeprecated-declarations"


The pragma directive #pragma clang diagnostic warning "-Wdeprecated-declarations" will cause deprecation warnings to be emitted as warnings for Clang, which contradicts the intent of suppressing these internal implementation warnings. This should be #pragma clang diagnostic ignored "-Wdeprecated-declarations" to suppress the warnings like it was before, matching the behavior for MSVC which uses disable : 4996.

Suggested change

# pragma GCC diagnostic warning "-Wdeprecated-declarations"

# elif defined(__clang__) || defined(__apple_build_version__)

# pragma clang diagnostic push

# pragma clang diagnostic warning "-Wdeprecated-declarations"

# pragma GCC diagnostic ignored "-Wdeprecated-declarations"

# elif defined(__clang__) || defined(__apple_build_version__)

# pragma clang diagnostic push

# pragma clang diagnostic ignored "-Wdeprecated-declarations"

Copilot · 2026-02-05T06:41:15Z

api/include/opentelemetry/logs/provider.h

+#    pragma GCC diagnostic warning "-Wdeprecated-declarations"
+#  elif defined(__clang__) || defined(__apple_build_version__)
+#    pragma clang diagnostic push
+#    pragma clang diagnostic warning "-Wdeprecated-declarations"


The pragma directive #pragma GCC diagnostic warning "-Wdeprecated-declarations" will cause deprecation warnings to be emitted as warnings for GCC, which contradicts the intent of suppressing these internal implementation warnings. This should be #pragma GCC diagnostic ignored "-Wdeprecated-declarations" to suppress the warnings like it was before, matching the behavior for MSVC which uses disable : 4996.

Suggested change

# pragma GCC diagnostic warning "-Wdeprecated-declarations"

# elif defined(__clang__) || defined(__apple_build_version__)

# pragma clang diagnostic push

# pragma clang diagnostic warning "-Wdeprecated-declarations"

# pragma GCC diagnostic ignored "-Wdeprecated-declarations"

# elif defined(__clang__) || defined(__apple_build_version__)

# pragma clang diagnostic push

# pragma clang diagnostic ignored "-Wdeprecated-declarations"

Copilot · 2026-02-05T06:41:15Z

api/include/opentelemetry/logs/provider.h

+#    pragma GCC diagnostic warning "-Wdeprecated-declarations"
+#  elif defined(__clang__) || defined(__apple_build_version__)
+#    pragma clang diagnostic push
+#    pragma clang diagnostic warning "-Wdeprecated-declarations"


The pragma directive #pragma clang diagnostic warning "-Wdeprecated-declarations" will cause deprecation warnings to be emitted as warnings for Clang, which contradicts the intent of suppressing these internal implementation warnings. This should be #pragma clang diagnostic ignored "-Wdeprecated-declarations" to suppress the warnings like it was before, matching the behavior for MSVC which uses disable : 4996.

Suggested change

# pragma GCC diagnostic warning "-Wdeprecated-declarations"

# elif defined(__clang__) || defined(__apple_build_version__)

# pragma clang diagnostic push

# pragma clang diagnostic warning "-Wdeprecated-declarations"

# pragma GCC diagnostic ignored "-Wdeprecated-declarations"

# elif defined(__clang__) || defined(__apple_build_version__)

# pragma clang diagnostic push

# pragma clang diagnostic ignored "-Wdeprecated-declarations"

codecov · 2026-02-05T06:54:31Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.99%. Comparing base (bb5fff0) to head (d798baa).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3845      +/-   ##
==========================================
+ Coverage   89.99%   89.99%   +0.01%     
==========================================
  Files         225      225              
  Lines        7168     7170       +2     
==========================================
+ Hits         6450     6452       +2     
  Misses        718      718

Files with missing lines	Coverage Δ
api/include/opentelemetry/logs/event_logger.h	`90.00% <ø> (ø)`
...include/opentelemetry/logs/event_logger_provider.h	`100.00% <ø> (ø)`
api/include/opentelemetry/logs/noop.h	`79.32% <100.00%> (+1.54%)`	⬆️
api/include/opentelemetry/logs/provider.h	`100.00% <100.00%> (ø)`

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

ThomsonTan · 2026-02-05T06:56:27Z

Could a test be tested for validation?

…arations

owent · 2026-02-05T09:27:28Z

Could a test be tested for validation?

Yes, tests are added.

…er.h

ThomsonTan · 2026-02-07T05:02:00Z

examples/common/logs_foo_library/CMakeLists.txt

+    list(REMOVE_ITEM COMMON_LOGS_FOO_COMPILE_OPTS
+         -Wno-error=deprecated-declarations)
+    set_target_properties(
+      common_logs_foo_library PROPERTIES COMPILE_OPTIONS


Would remove the option from the target property work? The option -Wno-error=deprecated-declarations seems added to the directory level at

opentelemetry-cpp/CMakeLists.txt

Line 197 in bb5fff0

add_compile_options(-Wno-error=deprecated-declarations)

The code already builds in CI in maintainer mode, why do we need extra changes in CMakeLists.txt ?

ThomsonTan · 2026-02-07T05:10:51Z

CHANGELOG needs to be updated.

marcalff · 2026-02-07T10:44:16Z

api/include/opentelemetry/logs/event_logger.h

+#  if defined(_MSC_VER)
+#    pragma warning(push)
+#    pragma warning(disable : 4996)
+#  elif defined(__GNUC__) && !defined(__clang__) && !defined(__apple_build_version__)
+#    pragma GCC diagnostic push
+#    pragma GCC diagnostic ignored "-Wdeprecated-declarations"
+#  elif defined(__clang__) || defined(__apple_build_version__)
+#    pragma clang diagnostic push
+#    pragma clang diagnostic ignored "-Wdeprecated-declarations"
+#  endif
+


This header file declares a deprecated class:

class OPENTELEMETRY_DEPRECATED EventLogger

Not tested on windows, but I in my understanding:

DECLARING a deprecated code does not raise a warning

USING a deprecated code does raise a warning

so there should be no changes in file event_logger.h and event_logger_provider.h.

I think this is different for MSVC. MSVC with /sdl fires C4996 at declaration sites too, not just usage, in that case the suppression here is needed.

@ThomsonTan @lalitb

With this change, code is deprecated and the deprecation warning is always suppressed and ignored, due to the pragma added.

This makes no sense to me, why deprecating in the first place then ?

Given that this patch is already approved by two maintainers, and given how it unblocks an issue downstream in opentelemetry-cpp-contribs (geneva), I am not blocking this merge it so it can be part of the 1.25 release, but I don't agree with this change.

If we don't want deprecation warnings at all, why not remove the OPENTELEMETRY_DEPRECATED tag, and remove all the pragma pilled up on top, to achieve exactly the same effect ?

This area should be simplified in a follow up PR, in my opinion.

Preparing the 1.25 release with warnings disabled for now, again, to unblock downstream.

lalitb · 2026-02-07T15:04:27Z

api/include/opentelemetry/logs/event_logger.h

+#  elif defined(__clang__) || defined(__apple_build_version__)
+#    pragma clang diagnostic push
+#    pragma clang diagnostic ignored "-Wdeprecated-declarations"
+#  endif


nit - not blocker, can be done in subsequent PR - this suppression block is repeated quite often in code. Probably we can use the macros

OTEL_INTERNAL_SUPPRESS_WARNING_PUSH OTEL_INTERNAL_SUPPRESS_DEPRECATED // ... code referencing deprecated types ... OTEL_INTERNAL_SUPPRESS_WARNING_POP

lalitb

LGTM. Good to include in the new release if rest of the reviewers agree.

Fixes deprecated warning

ee13c73

owent requested a review from a team as a code owner February 5, 2026 06:37

Copilot AI review requested due to automatic review settings February 5, 2026 06:37

Copilot started reviewing on behalf of owent February 5, 2026 06:38 View session

Copilot AI reviewed Feb 5, 2026

View reviewed changes

owent added 2 commits February 5, 2026 16:22

Enable deprecated warning in logs_foo_library to test deprecated decl…

d86b08d

…arations

Fixes deprecated declarations warnings

2be52f7

marcalff mentioned this pull request Feb 5, 2026

[RELEASE] Prepare release opentelemetry-cpp 1.25.0 #3844

Closed

owent and others added 2 commits February 5, 2026 18:15

Resolve deprecated warnings in event_logger.h and event_logger_provid…

cd63f5b

…er.h

Merge branch 'main' into fixes_3835

d798baa

ThomsonTan reviewed Feb 7, 2026

View reviewed changes

marcalff reviewed Feb 7, 2026

View reviewed changes

lalitb reviewed Feb 7, 2026

View reviewed changes

lalitb approved these changes Feb 7, 2026

View reviewed changes

ThomsonTan approved these changes Feb 7, 2026

View reviewed changes

ThomsonTan mentioned this pull request Feb 7, 2026

[RELEASE] Release opentelemetry-cpp 1.25.0 #3850

Merged

3 tasks

marcalff changed the title ~~Fixes deprecated warning~~ [BUILD] Ignore deprecated warning Feb 7, 2026

marcalff merged commit a61d05b into open-telemetry:main Feb 7, 2026
67 checks passed

BrewTestBot mentioned this pull request Feb 8, 2026

opentelemetry-cpp 1.25.0 Homebrew/homebrew-core#266383

Merged

1 task

Conversation

owent commented Feb 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Feb 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

ThomsonTan commented Feb 5, 2026

Uh oh!

owent commented Feb 5, 2026

Uh oh!

ThomsonTan Feb 7, 2026

Choose a reason for hiding this comment

Uh oh!

marcalff Feb 7, 2026

Choose a reason for hiding this comment

Uh oh!

ThomsonTan commented Feb 7, 2026

Uh oh!

marcalff Feb 7, 2026

Choose a reason for hiding this comment

Uh oh!

lalitb Feb 7, 2026

Choose a reason for hiding this comment

Uh oh!

marcalff Feb 7, 2026

Choose a reason for hiding this comment

Uh oh!

lalitb Feb 7, 2026

Choose a reason for hiding this comment

Uh oh!

lalitb left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

owent commented Feb 5, 2026 •

edited

Loading

codecov bot commented Feb 5, 2026 •

edited

Loading