Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scope config #3137

Draft
wants to merge 16 commits into
base: main
Choose a base branch
from
Draft

Add scope config #3137

wants to merge 16 commits into from

Conversation

psx95
Copy link
Contributor

@psx95 psx95 commented Nov 12, 2024

Re #2641

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

Copy link

netlify bot commented Nov 12, 2024

Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
🔨 Latest commit 28aae45
🔍 Latest deploy log https://app.netlify.com/sites/opentelemetry-cpp-api-docs/deploys/6736b1d75aa4b600084f7384

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

Attention: Patch coverage is 85.41667% with 7 lines in your changes missing coverage. Please review.

Project coverage is 87.81%. Comparing base (497eaf4) to head (e02d1c5).
Report is 164 commits behind head on main.

Files with missing lines Patch % Lines
sdk/src/trace/tracer_provider_factory.cc 50.00% 6 Missing ⚠️
sdk/src/trace/tracer.cc 83.34% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3137      +/-   ##
==========================================
+ Coverage   87.12%   87.81%   +0.69%     
==========================================
  Files         200      197       -3     
  Lines        6109     6181      +72     
==========================================
+ Hits         5322     5427     +105     
+ Misses        787      754      -33     
Files with missing lines Coverage Δ
sdk/include/opentelemetry/sdk/trace/tracer.h 100.00% <100.00%> (ø)
...dk/include/opentelemetry/sdk/trace/tracer_config.h 100.00% <100.00%> (ø)
...k/include/opentelemetry/sdk/trace/tracer_context.h 100.00% <ø> (ø)
sdk/src/trace/tracer_config.cc 100.00% <100.00%> (ø)
sdk/src/trace/tracer_context.cc 84.00% <100.00%> (+2.19%) ⬆️
sdk/src/trace/tracer_provider.cc 89.80% <100.00%> (+0.67%) ⬆️
sdk/src/trace/tracer.cc 81.97% <83.34%> (-0.48%) ⬇️
sdk/src/trace/tracer_provider_factory.cc 46.16% <50.00%> (+1.71%) ⬆️

... and 107 files with indirect coverage changes

@psx95 psx95 force-pushed the add-scope-config branch 2 times, most recently from fee7f7c to 15274c0 Compare November 15, 2024 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant