Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EXPORTER] Add logging for async gRPC errors #3108

Merged
merged 4 commits into from
Oct 24, 2024
Merged

[EXPORTER] Add logging for async gRPC errors #3108

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d461f13
[EXPORTER] Add logging for async gRPC errors
santigimeno Oct 22, 2024
8e551cf
Merge branch 'main' into santi/propagate_status
marcalff Oct 23, 2024
521460b
Update exporters/otlp/src/otlp_grpc_client.cc
marcalff Oct 24, 2024
18d94fb
Update exporters/otlp/src/otlp_grpc_client.cc
marcalff Oct 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion exporters/otlp/src/otlp_grpc_client.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,14 +207,19 @@ static sdk::common::ExportResult InternalDelegateAsyncExport(
stub->experimental_async()
# endif
->Export(call_data->grpc_context.get(), call_data->request, call_data->response,
[call_data, async_data](::grpc::Status grpc_status) {
[call_data, async_data, export_data_name](::grpc::Status grpc_status) {
--async_data->running_requests;
++async_data->finished_request_counter;

call_data->grpc_status = grpc_status;
if (call_data->grpc_status.ok())
{
call_data->export_result = opentelemetry::sdk::common::ExportResult::kSuccess;
} else {
marcalff marked this conversation as resolved.
Show resolved Hide resolved
OTEL_INTERNAL_LOG_ERROR("[OTLP GRPC Client] ERROR: Export "
<< export_data_name << " failed with status_code: \""
<< grpc_status.error_code() << "\" error_message: \""
<< grpc_status.error_message() << "\"");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not related to this PR, but we need to figure out some way of throttling, as this can otherwise flood the logs for the non-recoverable issues.

marcalff marked this conversation as resolved.
Show resolved Hide resolved
}

if (call_data->grpc_async_callback)
Expand Down
Loading