[TEST] Fix lifetime issues in prometheus test utils #2322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dashpole and @quentinmit this was informed by our discussion earlier today. Once it's merged we can use this approach in #2293 as well. |
Codecov Report
@@ Coverage Diff @@
## main #2322 +/- ##
=======================================
Coverage 87.45% 87.45%
=======================================
Files 199 199
Lines 5997 5997
=======================================
Hits 5244 5244
Misses 753 753 |
The MetricsData instance returned from these helpers outlived the Resource and InstrumentationScope instances that it pointed to.
punya
force-pushed
the
fix-lifetimes
branch
from
390bcc0
to
965f176
Compare
ThomsonTan
approved these changes
Sep 22, 2023
marcalff
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MetricsData instance returned from these helpers outlived the
Resource and InstrumentationScope instances that it pointed to.