-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EXPORTER] Export resource for prometheus #2301
Merged
Merged
Changes from all commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
dfefb44
Export resource for prometheus
owent ca3286a
Fix unit test in prometheus, fix resouce exporting for prometheus exp…
owent 1436368
Fix constructor
owent 22b8c94
Fix compiling problem
owent 3b15502
Fix invalid resource pointer in unit test of prometheus
owent 1ffba54
Fix "default member initializer" problem
owent 401a8ac
Merge remote-tracking branch 'github/main' into emits_resource_for_pr…
owent d2e144a
Add `target_info` metric.
owent a30ddf7
Merge remote-tracking branch 'github/main' into emits_resource_for_pr…
owent 02f4d04
Fix instance and job exporting
owent 004a4d4
Merge remote-tracking branch 'github/main' into emits_resource_for_pr…
owent 72ed751
Add options to let user to decide whether to populate target_info
owent 00b0b66
Fix warnings
owent 9f01fd4
Fix priority of conflict labels.
owent 5d24d88
Fix unit test
owent e50a3d6
Allow some attributes in resource attributes but not in metric attrib…
owent 88e9857
Change the info-typed target metric.
owent a0b322b
Do not ignore metric attributes.
owent 33d3a47
Merge remote-tracking branch 'github/main' into emits_resource_for_pr…
owent 0ab87c0
Merge remote-tracking branch 'github/main' into emits_resource_for_pr…
owent fcc397f
Fix unit tests after merged.
owent 23f29cd
Merge remote-tracking branch 'github/main' into emits_resource_for_pr…
owent 765eb99
Merge SanitizeName changes
owent c476939
Remove ignores in resource attributes
owent 3ebe160
Merge remote-tracking branch 'opentelemetry/main'
owent 422bca2
Remove labels conversations that should only be in target info.
owent d0f15f2
Remove unused variables.
owent bb62f0a
Populate target_info with every scrape
owent 9826f67
Merge remote-tracking branch 'opentelemetry/main'
owent db783e2
Fix style
owent 3517444
Merge remote-tracking branch 'opentelemetry/main'
owent dd737e3
Fix some legacy issues to remove `job` and `instance` labels.
owent b6ca2f2
Add scope for target-info
owent 0149d5c
Restore `+2` when reserve space for vector.
owent File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not related to this PR, but there is possibility of precision loss while casting from
int64_t
todouble
for larger values ( > 2^52) ofsum
. Good to have a issue to track this (I will create one) - to check for any such loss and log a warning. No changes required in this PR.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I add this static cast because it will trigger a warning with clang 16 and
-Werror
will make it a error.BTW:Do you think think it may have epsilon problem in the code
metric->histogram.sample_count = static_cast<std::uint64_t>(values[1]);
inPrometheusExporterUtils::SetValue
?